Livequery

[luigidellaquila]

Hi @phpnode

this is a pull request for live query support.
Please review this (especially connection.js line 360...) and if you need any info just let me know

Thanks a lot

[phpnode]

obj is defined twice in this function so the tests are failing, I would remove the obj declaration and replace this with:

return [
  Operation.LIVE_RESULT,
  token,
  operation,
  {
    content: content,
    type: 'd',
    cluster: clusterId,
    position: clusterPosition,
    version: version
  },
  offset
];

[luigidellaquila]

Hi Charles,

thank you very much, I'll fix it and will send another PR soon

Thanks

Luigi

2015-04-27 20:42 GMT+02:00 Charles Pick notifications@github.com:

In lib/transport/binary/protocol28/operation.js
#306 (comment):

•    offset+=4;
  

•    var clusterId = buffer.readInt16BE(offset);
  

•    offset+=2;
  

•    var clusterPosition = Long.fromBits(
  

•        buffer.readUInt32BE(offset + 4),
  

•        buffer.readInt32BE(offset)
  

•    ).toNumber();
  

•    offset+=8;
  

•    var contentLenght = buffer.readInt32BE(offset);
  

•    offset+=4;
  

•    var asString = buffer.toString('utf8', offset, offset + contentLenght);
  

•    offset += contentLenght;
  

•    var content = deserializer.deserialize(asString, this.data.transformerFunctions);
  

•    var obj = {};
  

obj is defined twice in this function so the tests are failing, I would
remove the obj declaration and replace this with:

return [
Operation.LIVE_RESULT,
token,
operation,
{
content: content,
type: 'd',
cluster: clusterId,
position: clusterPosition,
version: version
},
offset
];

—
Reply to this email directly or view it on GitHub
https://github.com/codemix/oriento/pull/306/files#r29177038.

[luigidellaquila]

Hi Charles,

Fix applied, let me know if the rest is ok

Thank you very much!

Luigi

2015-04-28 11:29 GMT+02:00 Luigi Dell'Aquila luigi.dellaquila@gmail.com:

Hi Charles,

thank you very much, I'll fix it and will send another PR soon

Thanks

Luigi

2015-04-27 20:42 GMT+02:00 Charles Pick notifications@github.com:

In lib/transport/binary/protocol28/operation.js
#306 (comment):

•    offset+=4;
  

•    var clusterId = buffer.readInt16BE(offset);
  

•    offset+=2;
  

•    var clusterPosition = Long.fromBits(
  

•        buffer.readUInt32BE(offset + 4),
  

•        buffer.readInt32BE(offset)
  

•    ).toNumber();
  

•    offset+=8;
  

•    var contentLenght = buffer.readInt32BE(offset);
  

•    offset+=4;
  

•    var asString = buffer.toString('utf8', offset, offset + contentLenght);
  

•    offset += contentLenght;
  

•    var content = deserializer.deserialize(asString, this.data.transformerFunctions);
  

•    var obj = {};
  

obj is defined twice in this function so the tests are failing, I would
remove the obj declaration and replace this with:

return [
Operation.LIVE_RESULT,
token,
operation,
{
content: content,
type: 'd',
cluster: clusterId,
position: clusterPosition,
version: version
},
offset
];

—
Reply to this email directly or view it on GitHub
https://github.com/codemix/oriento/pull/306/files#r29177038.

[luigidellaquila]

Hi @phpnode

I just applied the suggested fix. Let me know if the rest is ok

Thanks

Luigi

[phpnode]

@luigidellaquila thanks!

[gauravdhiman]

Can you kindly update the Readme with an example to use merged feature of LiveQuery.
I would like to use the LiveQuery feature for building Meteor package to make Meteor and OrientDB work together.

[phpnode]

@luigidellaquila please could you open another PR with that? :)

[luigidellaquila]

Of course I will ;-)

Thanks

Luigi

2015-05-20 15:57 GMT+02:00 Charles Pick notifications@github.com:

@luigidellaquila https://github.com/luigidellaquila please could you
open another PR with that? :)

—
Reply to this email directly or view it on GitHub
#306 (comment).