Skip to content

Escaping / (forward slash) causes SQL errors #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phpnode merged 2 commits into from
Jun 16, 2015
Merged

Escaping / (forward slash) causes SQL errors #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b9cae
Escaping / (forward slash) causes SQL errors
Ziink Jun 12, 2015
63849b5
Escaping / (forward slash) causes SQL errors
Ziink Jun 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ exports.escape = function (input) {
else if (char === '\\') {
chars[i] = '\\\\';
}
else if (char === '/' && i === 0) {
chars[i] = '\\/';
}
else {
chars[i] = char;
}
Expand Down Expand Up @@ -374,4 +371,4 @@ exports.requiresParens = function (input) {
*/
function ArrayLike () {}

exports.ArrayLike = ArrayLike;
exports.ArrayLike = ArrayLike;
22 changes: 22 additions & 0 deletions test/bugs/329-pullreq-do-not-escape-slash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
describe('Pull Request #329: Not escaping leading forward slash "(/)"', function () {
before(function () {
return CREATE_TEST_DB(this, 'testdb_PR_329');
});
after(function () {
return DELETE_TEST_DB('testdb_PR_329');
});
it('should still enable inserting record with field like "/// TE /// ST \\\\\\"', function () {
return this.db.insert().into('v').set({val: '/// TE /// ST \\\\\\'}).one()
.then(function (result) {
result.val.should.equal('/// TE /// ST \\\\\\');
});
});

it('should still enable where clause with field like "/// TE /// ST \\\\\\"', function () {
return this.db.select().from('v').where({val: '/// TE /// ST \\\\\\'}).one()
.then(function (result) {
result.val.should.equal('/// TE /// ST \\\\\\');
});
});

});
6 changes: 0 additions & 6 deletions test/core/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ describe('utils.prepare', function () {
it("should prepare SQL statements with parameters", function () {
utils.prepare("select from index:foo where key = :key", {key: 123}).should.equal("select from index:foo where key = 123");
});
it('should prepare SQL statements with parameters with tricky values', function () {
var text = utils.prepare("SELECT * FROM OUser WHERE foo = :foo", {
foo: '/// TE /// ST \\\\\\'
});
text.should.equal('SELECT * FROM OUser WHERE foo = "\\/// TE /// ST \\\\\\\\\\\\"');
});
it("should prepare SQL statements with date parameters", function () {
var date = new Date(Date.UTC(2015, 0, 5, 22, 7, 5, 435));
utils.prepare("select from index:foo where date = :date", {date: date}).should.equal("select from index:foo where date = date(\"2015-01-05 22:07:05.435\", \"yyyy-MM-dd HH:mm:ss.SSS\", \"UTC\")");
Expand Down