Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 435
Gates for the developer guide defects Asciidoctor cannot see#5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shai-almog
wants to merge
47
commits into
masterChoose a base branch
from
devguide-guards
base:master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Uh oh!
There was an error while loading. Please reload this page.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
684849a
Gates for the guide defects Asciidoctor cannot see
shai-almog eebe28f
Bank the four holes the constraints chapter no longer has
shai-almog 2555762
An unrelated subsection must not stand in for a swallowed chapter
shai-almog 877a371
The ifeval branch of the conditional test could never match
shai-almog 2a08ef7
Record why commented-out URLs are checked like any other
shai-almog f69f47c
Four links left the book to re-enter it, and nothing checked the anchor
shai-almog 82ed7bf
Two silent blind spots in the guards become loud refusals
shai-almog 520ced0
Check what swallows a heading, not whether its title turns up somewhere
shai-almog 9ffb68c
The slash rule rejected routes the site declares, and Hugo could move…
shai-almog 4f6f2a5
The PDF branch was never rendered, and an admonition counted as a lis…
shai-almog bbc2ee5
Three links from the old wiki went nowhere, and a directive is not a …
shai-almog 9a508aa
A Cloudflare function serves /files and /demos, and the PDF surrogate…
shai-almog 9d351ff
A five-dash block is still a literal block, and both scanners read in…
shai-almog 425e749
Guide figures render with a bundled font instead of the host's (#5668)
shai-almog 94a3b45
A comment block is not content, and img/ really does ship beside the …
shai-almog 773297b
The packaging exemption trusted the repository, not the published output
shai-almog 93b0518
The Introduction taught a dead IDE menu, an iTunes walkthrough and 20…
shai-almog b1f80df
Copyright headers for the two Windows wrappers, and duplicate include…
shai-almog cce4454
Refuse a conditional include at every depth, not only in the manifest
shai-almog aa6af63
A typo in the authority hid behind a correct hostname
shai-almog 41c3133
A listing hides content from the reader, not directives from the prep…
shai-almog 5e79881
The DNS root dot walked straight past the same-site checks
shai-almog b50b795
Read the fallback routes from the Function, and close the authority f…
shai-almog 2a25ea8
An inline directive is content, and an attribute-built URL is unreadable
shai-almog 2cc2941
Three Javadoc links pointed at a package that is spelt lowercase
shai-almog 50cf047
The Javadoc index documented a package the build deliberately removes
shai-almog 21e5d5c
Javadoc documents public types, and the index was recording every sou…
shai-almog 4c34787
An uppercase scheme was invisible, and the two slash rules had drifte…
shai-almog 6c1c945
A nested type was taken on trust, and an include hid inside an inline…
shai-almog db15d73
An invented middle level passed, and xref: was a third spelling nobod…
shai-almog c3ebc41
The publication-date fix was inert: the parser never stored the keys
shai-almog a1fa03d
Real nesting, real timestamps, and a comment stripper that ate braces
shai-almog a706801
The self-link rule existed on one branch and not the other
shai-almog 3e7b4a5
An inline comment became part of the value, and href tolerated no spaces
shai-almog 6655675
A nested annotation was rejected, and an attributed include was invis…
shai-almog ab628e1
Thirty-five Javadoc anchors used a form javadoc stopped emitting year…
shai-almog e7bb4ee
An unquoted href value is still an href
shai-almog d3ba948
The array brackets I added last round broke two links, and aliases ke…
shai-almog 92a9a91
A macro target is not prose, and a chapter has one place in the book
shai-almog e54e3f2
class-use pages are not generated, so linking to one is not fine
shai-almog bd3fb14
A reused fragment renders twice, and the CLDC sources trigger nothing
shai-almog 2982652
An anchor decorates the block below it; it is not the block
shai-almog 7cbeee1
Two package pages javadoc never writes, and multiplicity that stopped…
shai-almog d45e1da
Two leniency hatches that accepted anything shaped vaguely right
shai-almog 102bd45
A wildcard declares a slashed route just as a literal one does
shai-almog 79cb5e9
Rejecting javadoc's asset directories rather than enumerating them
shai-almog abdb22b
A titled listing is a listing, and a figure was never the promised code
shai-almog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 93 additions & 4 deletions
97 ...c/main/java/com/codenameone/developerguide/screenshots/PreAdvancedThemingScreenshots.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2 docs/demos/common/src/main/snippets/developer-guide/working-with-windows.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // Generated from docs/developer-guide source blocks. Edit the guide snippets here, not inline. | ||
| // tag::working-with-windows-bash-001[] | ||
| mvn -pl common package -Dcodename1.platform=windows -Dcodename1.buildTarget=windows-device | ||
| mvn package -Dcodename1.platform=win -Dcodename1.buildTarget=windows-device | ||
| // end::working-with-windows-bash-001[] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.