Skip to content

feat(termexec): handle agent animations - #145

Open
35C4n0r wants to merge 7 commits into
coder:mainfrom
35C4n0r:feat-handle-agent-animation
Open

feat(termexec): handle agent animations#145
35C4n0r wants to merge 7 commits into
coder:mainfrom
35C4n0r:feat-handle-agent-animation

Conversation

@35C4n0r

@35C4n0r35C4n0r commented Nov 17, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

feat(termexec): enhance dynamic header (animation) handling for different agent types

@35C4n0r35C4n0r self-assigned this Nov 17, 2025
@github-actions

github-actionsBot commented Nov 17, 2025

Copy link
Copy Markdown

✅ Preview binaries are ready!

To test with modules: agentapi_version = "agentapi_145" or download from: https://github.com/coder/agentapi/releases/tag/agentapi_145

@35C4n0r

35C4n0r commented Nov 18, 2025

Copy link
Copy Markdown
CollaboratorAuthor

formatting for the amp is ready and will be pushed in the next PR.

mafredri
mafredri reviewed Nov 19, 2025
View reviewed changes
Comment threadlib/termexec/utils.go Outdated
Comment threadlib/termexec/utils.go Outdated
Comment threadlib/termexec/utils.go Outdated
}
}
}
return animatedContentEnd, continueRemoving

@mafredrimafredriNov 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for this?

Comment threadlib/termexec/utils.go
if len(lines) >= 2 {
return 2, true
}
return -1, true

@mafredrimafredriNov 19, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is largely the same, but the continue removing variable seems new, perhaps we should ensure we've covered the new behavior with tests?

Comment threadlib/termexec/utils.go Outdated
Comment threadlib/termexec/utils.go Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mafredrimafredrimafredri left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@35C4n0r35C4n0r

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@35C4n0r@mafredri