Skip to content

fix(internal): harden file response handling - #302

Merged
jdomeracki-coder merged 3 commits into
mainfrom
fix/file-download-response-headers
Jun 22, 2026
Merged

fix(internal): harden file response handling#302
jdomeracki-coder merged 3 commits into
mainfrom
fix/file-download-response-headers

Conversation

@jdomeracki-coder

@jdomeracki-coderjdomeracki-coder commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep uploaded file responses inline while adding restrictive response policy headers.
  • Add a CSP with default-src 'none', sandbox, and frame-ancestors 'none'.
  • Avoid surfacing normal test Postgres socket cleanup as a background test error.
  • Add regression coverage for inline file response headers and absence of the legacy frame header.

Testing

  • bunx prettier --write internal/database/src/postgres-worker.ts internal/api/src/routes/files.server.ts internal/api/src/routes/files.test.ts
  • bunx biome check internal/database/src/postgres-worker.ts internal/api/src/routes/files.server.ts internal/api/src/routes/files.test.ts
  • bunx bun@1.3.14 test internal/database/src/postgres.test.ts internal/api/src/routes/agents/me/me.test.ts internal/api/src/routes/files.test.ts
  • bunx bun@1.3.14 test --rerun-each=50 internal/database/src/postgres.test.ts
  • bunx turbo typecheck --concurrency=1
  • bun run format:check

Generated by Coder Agents.

@vercel

vercelBot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
blinkReadyReadyPreview, CommentJun 22, 2026 8:52pm

Request Review

@jdomeracki-coderjdomeracki-coder changed the title fix(internal/api): harden file download responsesfix(internal/api): harden file responsesJun 22, 2026
@jdomeracki-coder
jdomeracki-coderforce-pushed the fix/file-download-response-headers branch from dc5e577 to 4a65c7eCompareJune 22, 2026 19:51
@jdomeracki-coder
jdomeracki-coder marked this pull request as ready for review June 22, 2026 20:13
@jdomeracki-coderjdomeracki-coder changed the title fix(internal/api): harden file responsesfix(internal): harden file response handlingJun 22, 2026
@jdomeracki-coder
jdomeracki-coder merged commit 40b21f6 into mainJun 22, 2026
5 of 6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jdomeracki-coder@kylecarbs