Refactor logout

[code-asher]

This should fix logging out on non-localhost domains and non-root paths (and some other cases like when using --proxy-domain).

It also moves the logout to a command and registers it from our client entry so we don't need to patch VS Code. This new command redirects to the logout endpoint where we clear the cookie from the server end.

It also only shows the logout when authentication is enabled.

Fixes#2984
Fixes#2985

Should unblock #2245 (reply in thread) as well

[code-asher]

Moving to a draft while I update the tests.

[codecov]

Codecov Report

Merging #3277 (8b2c78c) into main (9fe459a) will increase coverage by 7.87%.
The diff coverage is 85.71%.

@@ Coverage Diff @@## main #3277 +/- ##
==========================================
+ Coverage 46.90% 54.78% +7.87% 
==========================================
Files 23 23 Lines 1196 1265 +69 Branches 237 286 +49 ==========================================
+ Hits 561 693 +132 - Misses 451 460 +9 + Partials 184 112 -72 

Impacted Files	Coverage Δ
src/node/app.ts	70.73% <0.00%> (ø)
src/browser/register.ts	100.00% <100.00%> (+7.69%)	⬆️
src/common/util.ts	100.00% <100.00%> (+27.65%)	⬆️
src/node/http.ts	27.86% <0.00%> (-6.18%)	⬇️
src/node/vscode.ts	27.50% <0.00%> (-2.64%)	⬇️
src/node/wrapper.ts	33.12% <0.00%> (-0.43%)	⬇️
src/node/entry.ts	0.00% <0.00%> (ø)
src/common/emitter.ts	100.00% <0.00%> (ø)
src/node/proxy_agent.ts	0.00% <0.00%> (ø)
src/browser/pages/vscode.ts	0.00% <0.00%> (ø)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe459a...8b2c78c. Read the comment docs.

[jsjoeio]

will increase coverage by 7.87%.

DANG! Look at you 👏

[jsjoeio]

[oxy]

The one thing I'm slightly concerned about is that we have a 1.56 branch in the pipeline already which makes its own set of changes to menubarControl.ts, etc. - how much of this will we have to reimplement/re-fix in the 1.56 branch?

AFAICT its not too much work inside lib/vscode; but would still like any directions if things need changing.

[code-asher]

Ah yup actually I initially based this off your branch and switched back to main so I could get it merged in. 😛

All I did to resolve conflicts was to checkout the source (since we want to remove all our changes in that file). We can do that again in the 1.56 branch. Or we could resolve manually, I think the only conflict was the logService line and we'd want to remove the comment added above as well.