Uh oh!
There was an error while loading. Please reload this page.
feat: proxy URI environment variable - #4681
Merged
Merged
Conversation
This will let us test extension-related features (like the proxy URI). I removed the environment variables in the script because they override the ones you set yourself. We still set defaults in constants.ts.
This adds the VSCODE_PROXY_URI environment variable.
jsjoeio
approved these changes
Jan 4, 2022
jsjoeio
left a comment
Contributor
There was a problem hiding this comment.
This is an awesome! Seems like it'll be easier to test extensions with this 👏
Codecov Report
@@ Coverage Diff @@## main #4681 +/- ##
=======================================
Coverage 69.10% 69.10% =======================================
Files 29 29 Lines 1638 1638 Branches 341 341 =======================================
Hits 1132 1132 Misses 430 430 Partials 76 76 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus tests. Closes#1510.