Uh oh!
There was an error while loading. Please reload this page.
feat: add test for hash with empty string - #4814
Merged
Merged
Conversation
✨ Coder.com for PR #4814 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@## main #4814 +/- ##
=======================================
Coverage ? 69.25% =======================================
Files ? 29 Lines ? 1649 Branches ? 363 =======================================
Hits ? 1142 Misses ? 430 Partials ? 77
Continue to review full report at Codecov.
|
Uh oh!
There was an error while loading. Please reload this page.
jsjoeioforce-pushed
the
jsjoeio-hash-test
branch
from
February 3, 2022 19:53
f110bb6 to
cd488fbComparejsjoeio
commented
Feb 3, 2022
Comment on lines
-160
to
-165
| try { | ||
| return await argon2.hash(password) | ||
| } catch (error: any) { | ||
| logger.error(error) | ||
| return "" | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
✍🏼 as discussed with @code-asher, this will only throw if you throw in something other than string (like number). Since TS will prevent that, we don't need the try/catch block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional test for the
hashfunction.Fixes N/A
#TestingMondays