Skip to content

revert(docs): partially revert 326a1d1862872955cec062030df2bd103799a1eb - #5095

Merged
jsjoeio merged 1 commit into
mainfrom
jsjoeio/update-npm-docs
Apr 13, 2022
Merged

revert(docs): partially revert 326a1d1862872955cec062030df2bd103799a1eb#5095
jsjoeio merged 1 commit into
mainfrom
jsjoeio/update-npm-docs

Conversation

@jsjoeio

Copy link
Copy Markdown
Contributor

We tried to switch from yarn to npm because yarn ignores lockfiles
but learned that we missed a few key things.

For now, we are reverting docs and a few other changes that suggested
using npm instead of yarn until we fully remove yarn from the
codebase.

Related to #5071

We tried to switch from `yarn` to `npm` because `yarn` ignores lockfiles
but learned that we missed a few key things.
For now, we are reverting docs and a few other changes that suggested
using `npm` instead of `yarn` until we fully remove `yarn` from the
codebase.
t Please enter the commit message for your changes. Lines starting
@jsjoeiojsjoeio added this to the April 2022 milestone Apr 13, 2022
@jsjoeio
jsjoeio requested a review from a teamApril 13, 2022 16:56
@jsjoeiojsjoeio self-assigned this Apr 13, 2022
@github-actions

Copy link
Copy Markdown

✨ code-server docs for PR #5095 is ready! It will be updated on every commit.

@jsjoeio
jsjoeio enabled auto-merge (squash) April 13, 2022 16:59
@jsjoeio
jsjoeio temporarily deployed to npm April 13, 2022 17:01 Inactive
@codecov

codecovBot commented Apr 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #5095 (ff49ab0) into main (0e1f396) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## main #5095 +/- ##
=======================================
Coverage 71.33% 71.33% =======================================
Files 30 30 Lines 1685 1685 Branches 374 374 =======================================
Hits 1202 1202 Misses 413 413 Partials 70 70 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1f396...ff49ab0. Read the comment docs.

@github-actions

Copy link
Copy Markdown

✨ code-server dev build published to npm for PR #5095!

  • Last publish status: success
  • Commit: ff49ab0

To install in a local project, run:

npm install @coder/code-server-pr@5095

To install globally, run:

npm install -g @coder/code-server-pr@5095

@jsjoeio
jsjoeio merged commit e7e6c16 into mainApr 13, 2022
@jsjoeio
jsjoeio deleted the jsjoeio/update-npm-docs branch April 13, 2022 17:15
@jsjoeiojsjoeio modified the milestones: April 2022, 4.3.0Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
We tried to switch from `yarn` to `npm` because `yarn` ignores lockfiles
but learned that we missed a few key things.
For now, we are reverting docs and a few other changes that suggested
using `npm` instead of `yarn` until we fully remove `yarn` from the
codebase.
t Please enter the commit message for your changes. Lines starting
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jsjoeio@code-asher