Uh oh!
There was an error while loading. Please reload this page.
chore: fix npm publish logic - #5493
Merged
Merged
Conversation
coadler
previously approved these changes
Aug 23, 2022
jsjoeio
enabled auto-merge (squash)
August 23, 2022 16:07
Codecov Report
@@ Coverage Diff @@## main #5493 +/- ##
=======================================
Coverage 72.44% 72.44% =======================================
Files 30 30 Lines 1673 1673 Branches 366 366 =======================================
Hits 1212 1212 Misses 398 398 Partials 63 63 Continue to review full report at Codecov.
|
jsjoeio
marked this pull request as draft
August 23, 2022 16:16
auto-merge was automatically disabled
August 23, 2022 16:16
Pull request was converted to draft
jsjoeio
commented
Aug 23, 2022
ContributorAuthor
Sadly, this fix did not work: https://github.com/coder/code-server/runs/7977694661?check_suite_focus=true#step:4:19 |
npm changed the way the `npm view` command handles missing versions. Before it exited with a non-error. Now it errors. Ref: npm/cli#5035 This modifies the script logic to handle those new changes.
jsjoeioforce-pushed
the
jsjoeio/npm-cache
branch
from
August 23, 2022 18:13
57d2cad to
dddfd22Comparejsjoeio
marked this pull request as ready for review
August 23, 2022 18:13
code-asher
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After this landed npm/cli#5035, it broke our script. This PR catches the error thrown if the version is missing and handles it accordingly. I also cleaned up some of the output so the logs are easier to read.