Uh oh!
There was an error while loading. Please reload this page.
docs: remove references to installing with yarn in favor of npm - #5518
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jsjoeio
left a comment
There was a problem hiding this comment.
Woo! Thanks for doing this!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dd7c740 to
ead5c68CompareCodecov Report
Additional details and impacted files@@ Coverage Diff @@## main #5518 +/- ##
=======================================
Coverage 72.44% 72.44% =======================================
Files 30 30 Lines 1673 1673 Branches 366 366 =======================================
Hits 1212 1212 Misses 398 398 Partials 63 63 Continue to review full report at Codecov.
|
edvincent
commented
Aug 29, 2022
Actually... Where's my head. Forgot about the |
jsjoeio
commented
Aug 29, 2022
Nice catch! Remind me again, why do we need this? |
edvincent
commented
Aug 29, 2022
https://github.com/coder/code-server/blob/main/ci/build/npm-postinstall.sh#L95-L101 Now, is it actually needed? Not sure. Definitely something I'm happy to look into in the future. |
jsjoeio
commented
Aug 29, 2022
I honestly can't remember. @code-asher might know. Probably fine to add for now then we can revert/fix if needed. |
code-asher
commented
Aug 30, 2022
I think we only need it if someone is installing code-server with root because NPM will drop permissions in the post install scripts making the code-server install fail. |
edvincent
commented
Aug 30, 2022
So we should add a check for the user running the script, and only show the warning if it's |
code-asher
commented
Aug 30, 2022
via email
Yeah I think that would be ideal!! |
Follow-up of #5071 (comment) to update the docs.
Only left references to
yarncommands for the development process.