Skip to content

docs: remove references to installing with yarn in favor of npm - #5518

Merged
code-asher merged 1 commit into
coder:mainfrom
edvincent:docs-yarn
Aug 30, 2022
Merged

docs: remove references to installing with yarn in favor of npm#5518
code-asher merged 1 commit into
coder:mainfrom
edvincent:docs-yarn

Conversation

@edvincent

Copy link
Copy Markdown
Contributor

Follow-up of #5071 (comment) to update the docs.

Only left references to yarn commands for the development process.

@edvincent
edvincent requested a review from a team as a code ownerAugust 29, 2022 20:19
Comment threaddocs/termux.md Outdated

@jsjoeiojsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Thanks for doing this!

Comment threaddocs/termux.md Outdated
Comment threaddocs/install.md Outdated
@jsjoeiojsjoeio self-assigned this Aug 29, 2022
@jsjoeiojsjoeio added the docs Documentation related label Aug 29, 2022
@jsjoeiojsjoeio added this to the August 2022 milestone Aug 29, 2022
@edvincent
edvincentforce-pushed the docs-yarn branch 2 times, most recently from dd7c740 to ead5c68CompareAugust 29, 2022 20:31
@edvincent
edvincent requested a review from jsjoeioAugust 29, 2022 21:13
@codecov

codecovBot commented Aug 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #5518 (ae4d210) into main (101d4ee) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #5518 +/- ##
=======================================
Coverage 72.44% 72.44% =======================================
Files 30 30 Lines 1673 1673 Branches 366 366 =======================================
Hits 1212 1212 Misses 398 398 Partials 63 63 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101d4ee...ae4d210. Read the comment docs.

@edvincent

Copy link
Copy Markdown
ContributorAuthor

Actually... Where's my head. Forgot about the --unsafe-perm that npm requires... Updating coming up!

@jsjoeio

Copy link
Copy Markdown
Contributor

Actually... Where's my head. Forgot about the --unsafe-perm that npm requires... Updating coming up!

Nice catch! Remind me again, why do we need this?

@edvincent

Copy link
Copy Markdown
ContributorAuthor

Nice catch! Remind me again, why do we need this?

https://github.com/coder/code-server/blob/main/ci/build/npm-postinstall.sh#L95-L101

Now, is it actually needed? Not sure. Definitely something I'm happy to look into in the future.

@jsjoeio

Copy link
Copy Markdown
Contributor

I honestly can't remember. @code-asher might know. Probably fine to add for now then we can revert/fix if needed.

@code-asher

Copy link
Copy Markdown
Member

I think we only need it if someone is installing code-server with root because NPM will drop permissions in the post install scripts making the code-server install fail.

@edvincent

Copy link
Copy Markdown
ContributorAuthor

I think we only need it if someone is installing code-server with root because NPM will drop permissions in the post install scripts making the code-server install fail.

So we should add a check for the user running the script, and only show the warning if it's root? Happy to play around with that and send a separate PR for that in the next couple of days.

@code-asher

code-asher commented Aug 30, 2022 via email

Copy link
Copy Markdown
Member

@code-asher
code-asher merged commit ef3f4e8 into coder:mainAug 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@edvincent@jsjoeio@code-asher