ci: restrict benchmark workflow to bench/ branches only by ammario · Pull Request #77 · coder/httpjail

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammario · 2025-10-03T15:50:37Z

Summary

Change benchmark workflow to only run on bench/** branches or manual workflow dispatch
Remove automatic benchmark runs on all PRs to main

Motivation

Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:

On branches prefixed with bench/ (e.g., bench/optimize-rules)
Via manual workflow dispatch

Test Plan

Verify benchmarks don't run on regular PRs
Verify benchmarks run on bench/ prefixed branches
Verify workflow_dispatch still works for manual triggers

🤖 Generated with Claude Code

Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@codex fix this CI failure
@codex address that feedback

chatgpt-codex-connector · 2025-10-03T15:51:51Z

 on:
 workflow_dispatch:
+ push:
+ branches:
+ - 'bench/**'
 pull_request:
- branches: [main]
- paths:
- - 'src/rules/**'
- - 'benches/**'
- - '.github/workflows/benchmark.yml'
+ branches:
+ - 'bench/**'


Misconfigured pull_request filter prevents benchmarks from running
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.

ammarioand others added 2 commits October 3, 2025 10:50

Merge branch 'main' into ci-bench
b290523

ammario enabled auto-merge (squash) October 3, 2025 15:51

chatgpt-codex-connectorBot reviewed Oct 3, 2025
View reviewed changes