Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

feat(devcontainers-cli): add devcontainers-cli module - #425

Merged
defelmnq merged 16 commits into
mainfrom
vvi-16432
Apr 16, 2025
Merged

feat(devcontainers-cli): add devcontainers-cli module#425
defelmnq merged 16 commits into
mainfrom
vvi-16432

Conversation

@defelmnq

@defelmnqdefelmnq commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Related to this issue

Create a new module to install @devcontainers/cli using npm.

@defelmnqdefelmnq self-assigned this Apr 10, 2025
@defelmnqdefelmnq added the coder_script Needs `coder_script` label Apr 10, 2025
defelmnq
defelmnq commented Apr 10, 2025
View reviewed changes
Comment threaddevcontainers-cli/main.tf
@defelmnq
defelmnq requested a review from mtojekApril 11, 2025 13:00
mtojek
mtojek reviewed Apr 11, 2025
View reviewed changes
Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/README.md Outdated
```tf
module "devcontainers-cli" {
source = "registry.coder.com/modules/devcontainers-cli/coder"
version = "release/claude-code/1.0.32"

@mtojekmtojekApr 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does release/claude-code/1.0.32 exist or is it an example?

@defelmnqdefelmnqApr 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is enforced by the update-version.sh script - not sure if @matifali has more info here on why.

@mafredrimafredriApr 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be release/devcontainers-cli/1.0.0.

mafredri
mafredri reviewed Apr 14, 2025
View reviewed changes
Comment threaddevcontainers-cli/README.md
Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
@mafredri

mafredri commented Apr 14, 2025

Copy link
Copy Markdown
Member

It might be nice to add Docker detection here as well and print a WARNING if docker command isn't found.

@defelmnq
defelmnq requested review from mafredri and mtojekApril 14, 2025 17:41
@defelmnq

defelmnq commented Apr 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @mafredri and @mtojek for the review - I added :

  • Detection of Docker
  • Support for pnpm and yarn
  • Fixes some return code and log lines

A question asked by Marcin about Does release/claude-code/1.0.32 exist or is it an example?
-> This one is enforced by the CI , maybe @matifali has more knowledge of why.

About naming, I'm up to keep devcontainers/cli as its explicit and map to the package.

mafredri
mafredri reviewed Apr 14, 2025
View reviewed changes

@mafredrimafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions but otherwise looking good, thanks for implementing support for multiple package managers! 🎉

Comment threaddevcontainers-cli/README.md Outdated
```tf
module "devcontainers-cli" {
source = "registry.coder.com/modules/devcontainers-cli/coder"
version = "release/claude-code/1.0.32"

@mafredrimafredriApr 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be release/devcontainers-cli/1.0.0.

Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
@defelmnq
defelmnq requested a review from mafredriApril 14, 2025 20:41
@matifalimatifali removed the coder_script Needs `coder_script` label Apr 14, 2025
mtojek
mtojek approved these changes Apr 15, 2025
View reviewed changes

@mtojekmtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mafredri
mafredri approved these changes Apr 15, 2025
View reviewed changes

@mafredrimafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor optional adjustments to improve the output, but nothing blocking on my side. Nice work!

Comment threaddevcontainers-cli/run.sh Outdated
Comment threaddevcontainers-cli/run.sh Outdated
defelmnqand others added 2 commits April 15, 2025 13:27
@defelmnq@mafredri
Update devcontainers-cli/run.sh
67dd5ea
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@defelmnq@mafredri
Update devcontainers-cli/run.sh
8936b9a
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@defelmnq

defelmnq commented Apr 15, 2025

Copy link
Copy Markdown
ContributorAuthor

PR Is ready, currently waiting for #426 to have easier versioning.

matifali
matifali approved these changes Apr 16, 2025
View reviewed changes

@matifalimatifali left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the correct version. With rebased after #431, We should be able to push a tag release/devcontainers-cli/v1.0.0. This is an ad-hoc arrangement until #426 is finalized.

@defelmnq

defelmnq commented Apr 16, 2025

Copy link
Copy Markdown
ContributorAuthor

All good for me with @matifali last changes ✅ Thanks.

@defelmnq
defelmnq merged commit d4b4ebd into mainApr 16, 2025
@defelmnq
defelmnq deleted the vvi-16432 branch April 16, 2025 10:40
@matifalimatifali linked an issue Apr 29, 2025 that may be closed by this pull request
feat: create a new "Install Dev Container feature" module #307
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@mafredrimafredrimafredri approved these changes
@matifalimatifalimatifali approved these changes
@mtojekmtojekmtojek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@defelmnqdefelmnq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: create a new "Install Dev Container feature" module

4 participants

@defelmnq@mafredri@matifali@mtojek