Uh oh!
There was an error while loading. Please reload this page.
chore: remove it wrappers from required variables tests - #442
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test code by removing unnecessary it wrapper blocks from required variables tests in the jfrog-oauth and jfrog-token modules. The change simplifies the test structure by calling testRequiredVariables directly within the describe block instead of wrapping it in individual test cases.
- Removes
itwrapper blocks fromtestRequiredVariablescalls - Simplifies test structure in both modules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| registry/coder/modules/jfrog-token/main.test.ts | Removes it wrapper from required variables test |
| registry/coder/modules/jfrog-oauth/main.test.ts | Removes it wrapper from required variables test |
DevelopmentCats
marked this pull request as ready for review
September 30, 2025 00:14
matifali
approved these changes
Sep 30, 2025
Uh oh!
There was an error while loading. Please reload this page.
DevelopmentCats added a commit
that referenced
this pull request
May 11, 2026
…urce references Skills content now lives in source repos (e.g., coder/skills) instead of being duplicated in the registry. Each namespace declares its skill source repo(s) in a single registry/<namespace>/skills/README.md with a sources field in the frontmatter. Changes: - Replace per-skill directories (coder-modules/, coder-templates/) with a single registry/coder/skills/README.md that references coder/skills - Revert .agents/skills/ frontmatter changes (those files will move to coder/skills repo) - Revert version-bump.sh and tag_release.sh skill-specific version extraction (versioning lives in source repos now) - Keep CI/CD path triggers for registry/**/skills/** so catalogue metadata changes trigger deployment The registry-server build pipeline (PR #442) will need to be updated to clone source repos declared in the README.md frontmatter and auto-discover skills from them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove it wrappers from required variables tf test in jfrog-oauth and jfrog-token modules. This solves the failing tf tests that we were encountering in all PR's across the board.
Type of Change
Testing & Validation
bun test)bun run fmt)Related Issues