Skip to content

Add expiration date to vouchers - #477

Open
Eslam-Nawara wants to merge 7 commits into
developmentfrom
add-expiration-date-to-vouchers
Open

Add expiration date to vouchers#477
Eslam-Nawara wants to merge 7 commits into
developmentfrom
add-expiration-date-to-vouchers

Conversation

@Eslam-Nawara

@Eslam-NawaraEslam-Nawara commented Dec 4, 2023

Copy link
Copy Markdown
Collaborator

Description

add expiration date to vouchers

Related Issues

@Eslam-Nawara
Eslam-Nawaraforce-pushed the add-expiration-date-to-vouchers branch from c7d4a22 to 60893ddCompareDecember 4, 2023 15:28
@Eslam-Nawara
Eslam-Nawaraforce-pushed the add-expiration-date-to-vouchers branch from 76b07ee to 67fd8ffCompareDecember 11, 2023 11:54
rawdaGastan
rawdaGastan requested changes Dec 11, 2023
View reviewed changes
Comment threadserver/app/setup.go

err := os.WriteFile(configPath, []byte(config), 0644)
assert.NoError(t, err)
if !assert.NoError(t, err) {

@rawdaGastanrawdaGastanDec 11, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use assert.error

@Eslam-NawaraEslam-NawaraDec 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert changes the state of the testing object t, fa if I used assert.Error so every time the err = nil (meaning the test had bassed), the t object would report that the test failed

Comment threadserver/app/user_handler.go Outdated
Comment threadserver/app/user_handler.go Outdated
Comment threadserver/app/voucher_handler.go Outdated
Comment threadserver/deployer/deployer.go
Comment threadserver/deployer/k8s_deployer.go Outdated
ClusterContract: int(k8sContractID),
Master: master,
Workers: workers,
ExpirationDate: time.Now().Add(time.Duration(k8sDeployInput.Duration) * 30 * 24 * time.Hour).Truncate(24 * time.Hour),

@rawdaGastanrawdaGastanDec 11, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using hours?

@Eslam-NawaraEslam-NawaraDec 12, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no time.Month duration const to use it directly, max is time.Hour fa I use it to get a month

Comment threadserver/internal/config_parser.go
Comment threadserver/models/k8s.go Outdated
Comment threadserver/models/quota.go Outdated
Comment threadserver/models/quota.go Outdated
@Eslam-Nawara
Eslam-Nawara marked this pull request as ready for review December 27, 2023 08:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawdaGastanrawdaGastanAwaiting requested review from rawdaGastanrawdaGastan is a code owner
@xmonaderxmonaderAwaiting requested review from xmonaderxmonader is a code owner
@AlaaElattarAlaaElattarAwaiting requested review from AlaaElattar
@AbdelrahmanElawadyAbdelrahmanElawadyAwaiting requested review from AbdelrahmanElawady
@samaradelsamaradelAwaiting requested review from samaradel
@maayarosamamaayarosamaAwaiting requested review from maayarosama
@zaelgoharyzaelgoharyAwaiting requested review from zaelgoharyzaelgohary is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eslam-Nawara@rawdaGastan