Skip to content

Add the config file option - #19

Closed
peternewman wants to merge 7 commits into
masterfrom
peternewman-config-option
Closed

Add the config file option#19
peternewman wants to merge 7 commits into
masterfrom
peternewman-config-option

Conversation

@peternewman

@peternewmanpeternewman commented Sep 1, 2020

Copy link
Copy Markdown
Collaborator

Implement codespell-project/codespell#1668 within the action.

Blocked on a new release. This needs version 1.18.0 or greater to be released to work, so we should avoid merging until then to avoid the confusion.

@peternewmanpeternewman added the enhancement New feature or request label Sep 1, 2020
@peternewmanpeternewman added this to the Codespell-2.0 milestone Sep 1, 2020
@peternewman

Copy link
Copy Markdown
CollaboratorAuthor

Should probably add some BATS tests too...

@vadi2

Copy link
Copy Markdown
Contributor

This would be great to have, since it'll allow the user to extract the config to a separate file - then usable by both CI and locally.

@louim

Copy link
Copy Markdown

@peternewman it would be great to merge this. It would make it easier to use the same config locally and on the CI. Is there something blocking it? I see version 1.18.0 was mentioned in the original description, but now that it has been released, I think this is good to go?

@yarikoptic

Copy link
Copy Markdown

ping on this PR. Now there is an issue it can close: #67

@larsoner

Copy link
Copy Markdown
Member

CIs are red and there is a conflict, @yarikoptic or @louim would you like to take over?

@rdimaio

Copy link
Copy Markdown
Contributor

CIs are red and there is a conflict, @yarikoptic or @louim would you like to take over?

I've continued this PR here #80, fixing the CI and the conflict

@Piedone

This comment was marked as off-topic.

@larsoner

Copy link
Copy Markdown
Member

Superseded by #80

@larsonerlarsoner closed this Nov 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@peternewman@vadi2@louim@yarikoptic@larsoner@rdimaio@Piedone