Skip to content

Check errors don't exist as valid words in the aspell dictionary - #1142

Merged
larsoner merged 53 commits into
masterfrom
peternewman-aspell-dict-check
Apr 6, 2020
Merged

Check errors don't exist as valid words in the aspell dictionary#1142
larsoner merged 53 commits into
masterfrom
peternewman-aspell-dict-check

Conversation

@peternewman

@peternewmanpeternewman commented May 29, 2019

Copy link
Copy Markdown
Collaborator

Progress on #1140 (other examples need checking)
Closes#1109
Progress on #410 (other examples need checking)

  • Either install for Appveyor (see here and here), or don't require the test to run on that platform
  • Encoding - Probably need to do this too
  • Word list, pneumonic is in the large word list, but not the normal one, Br/Am English.

@peternewmanpeternewman added dictionary Changes to the dictionary enhancement labels May 29, 2019
@peternewmanpeternewman mentioned this pull request Jul 7, 2019
Resync Peternewman-aspell-dict-check with master
@larsoner

Copy link
Copy Markdown
Member

@peternewman do you want help with this one? It seems useful

@peternewman

Copy link
Copy Markdown
CollaboratorAuthor

@peternewman do you want help with this one? It seems useful

Yeah probably. Sorry I've been tied up with lots of other stuff.

I got it working and removed the ones I obviously recognised or which seemed popular, so it served it's initially purpose. My feeling was the multiple dictionary stuff probably wants doing next before the others are then migrated into a separate potential typos dictionary. I think most of these are generally unlikely to be false positives most of the time, so it seemed a shame to drop them currently.

@larsoner

Copy link
Copy Markdown
Member

@peternewman I took a stab at adding multi-dict support. Can you see if these changes do something like what you'd want? If so, feel free to rebase or merge so that CIs can actually run. But tests at least pass locally

@larsoner

Copy link
Copy Markdown
Member

Okay @peternewman I think I'm +1 for merge on this one so if you're happy feel free to merge

@peternewman

peternewman commented Apr 6, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Okay @larsoner , I think the logic of this is now working as expected, certainly chancel is a valid word so I think should be in rare, but do you want to sanity check before they all get moved.

Do you want to review, if you're happy move those 5 words into rare, then I'm happy for it to be merged and it probably looks better if you hit the button anyway!

@larsoner

Copy link
Copy Markdown
Member

@peternewman travis is not happy

@larsoner

Copy link
Copy Markdown
Member

... ahh, that's what the chancel comment is about. I'll push a commit to move

Comment threadcodespell_lib/tests/test_dictionary.py Outdated
@larsoner
larsoner merged commit d978da6 into masterApr 6, 2020
@larsoner

Copy link
Copy Markdown
Member

Okay let's keep things moving, thanks for the iterations @peternewman !

@larsoner
larsoner deleted the peternewman-aspell-dict-check branch April 6, 2020 16:54
@peternewman

Copy link
Copy Markdown
CollaboratorAuthor

Great, thanks for doing most of the leg work on it!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionaryChanges to the dictionaryenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible incorrect values and disable multiple choice mut is a keyword in rust

2 participants

@peternewman@larsoner