Skip to content

Add aminat{or|ion|ions}->animat{or|ion|ions} - #1220

Merged
bl-ue merged 5 commits into
codespell-project:masterfrom
luzpaz:amination
Jun 13, 2021
Merged

Add aminat{or|ion|ions}->animat{or|ion|ions}#1220
bl-ue merged 5 commits into
codespell-project:masterfrom
luzpaz:amination

Conversation

@luzpaz

Copy link
Copy Markdown
Collaborator

aminator is a legit word but not frequently used in comparison to it being a typo. IMO this PR is merited.

@larsoner

Copy link
Copy Markdown
Member

I've never heard of it and it wasn't in the dictionary I checked

Comment threadcodespell_lib/data/dictionary.txt Outdated
@larsoner

Copy link
Copy Markdown
Member

Okay, just have to convince @peternewman then :)

@peternewman

Copy link
Copy Markdown
Collaborator

Okay, just have to convince @peternewman then :)

I still don't see why they can't all go in a secondary dictionary (aside from that capability not currently being present, but it can't be too hard).

I know it's called codespell, but it strikes me one of the fairly unique features of codespell is the curated nature of the dictionary, it doesn't find words not in it's dictionary, the dictionary is a list of genuine or likely typos and suggested corrections. If you're writing about something niche like enzyme catalysation, you may still want to use codespell to avoid getting flooded with false positive words that a normal dictionary doesn't know about.

Given that, to keep the core dictionary pure, we need to have some CI to keep on top of it, otherwise we get more and more of https://github.com/codespell-project/codespell/pull/1181/files and https://travis-ci.org/codespell-project/codespell/jobs/562631674 . I'm sure everyone could find at least one word in #1181 they would have or have already legitimately used in a comment.

@peternewmanpeternewman added the dictionary Changes to the dictionary label Sep 8, 2019
@larsoner

Copy link
Copy Markdown
Member

@luzpaz this (and possibly other) PR(s) can now be rebased and refactored given that we have multiple dictionaries

@luzpaz

Copy link
Copy Markdown
CollaboratorAuthor

@luzpaz this (and possibly other) PR(s) can now be rebased and refactored given that we have multiple dictionaries

I'm a little bit turned around. How should I proceed?

@larsoner

Copy link
Copy Markdown
Member

Rebase or merge your PR, then make use of new dictionaries. Or close the PRs and start over if it's easier

@peternewman

Copy link
Copy Markdown
Collaborator

If it's correcting to itself, i.e. it's a real word, put it in the rare dictionary ( https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_rare.txt ), otherwise you can proceed as normal (unless it's a name etc).

luzpaz added 2 commits June 14, 2020 06:21
`aminator` is a legit word but not frequently used in comparison to it being a typo. IMO this PR is merited.
@luzpaz

Copy link
Copy Markdown
CollaboratorAuthor

Revised commit, please see 1fe6501

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Comment threadcodespell_lib/data/dictionary_rare.txt Outdated
Comment threadcodespell_lib/data/dictionary.txt Outdated
@bl-ue
bl-ue enabled auto-merge (squash) June 13, 2021 15:02
@bl-ue
bl-ue merged commit 07e028a into codespell-project:masterJun 13, 2021
@luzpaz
luzpaz deleted the amination branch June 13, 2021 16:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionaryChanges to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@luzpaz@larsoner@peternewman@sebweb3r@arm-in@bl-ue