Uh oh!
There was an error while loading. Please reload this page.
Add aminat{or|ion|ions}->animat{or|ion|ions} - #1220
Conversation
larsoner
commented
Aug 12, 2019
I've never heard of it and it wasn't in the dictionary I checked |
Uh oh!
There was an error while loading. Please reload this page.
larsoner
commented
Aug 12, 2019
Okay, just have to convince @peternewman then :) |
peternewman
commented
Aug 12, 2019
I still don't see why they can't all go in a secondary dictionary (aside from that capability not currently being present, but it can't be too hard). I know it's called codespell, but it strikes me one of the fairly unique features of codespell is the curated nature of the dictionary, it doesn't find words not in it's dictionary, the dictionary is a list of genuine or likely typos and suggested corrections. If you're writing about something niche like enzyme catalysation, you may still want to use codespell to avoid getting flooded with false positive words that a normal dictionary doesn't know about. Given that, to keep the core dictionary pure, we need to have some CI to keep on top of it, otherwise we get more and more of https://github.com/codespell-project/codespell/pull/1181/files and https://travis-ci.org/codespell-project/codespell/jobs/562631674 . I'm sure everyone could find at least one word in #1181 they would have or have already legitimately used in a comment. |
larsoner
commented
Apr 6, 2020
@luzpaz this (and possibly other) PR(s) can now be rebased and refactored given that we have multiple dictionaries |
luzpaz
commented
Apr 6, 2020
I'm a little bit turned around. How should I proceed? |
larsoner
commented
Apr 6, 2020
Rebase or merge your PR, then make use of new dictionaries. Or close the PRs and start over if it's easier |
peternewman
commented
Apr 7, 2020
If it's correcting to itself, i.e. it's a real word, put it in the rare dictionary ( https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_rare.txt ), otherwise you can proceed as normal (unless it's a name etc). |
`aminator` is a legit word but not frequently used in comparison to it being a typo. IMO this PR is merited.
luzpaz
commented
Jun 14, 2020
Revised commit, please see 1fe6501 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aminatoris a legit word but not frequently used in comparison to it being a typo. IMO this PR is merited.