Skip to content

Update dictionary with more misspellings and disabled names - #1425

Merged
peternewman merged 1 commit into
codespell-project:masterfrom
qyearsley:master
Mar 6, 2020
Merged

Update dictionary with more misspellings and disabled names#1425
peternewman merged 1 commit into
codespell-project:masterfrom
qyearsley:master

Conversation

@qyearsley

Copy link
Copy Markdown
Contributor

This PR:

  • Disables a few more person names: Amin, Ang, Anny, Bae, Chang, Que, Sargent, Wen
  • Also disables Synopsys (company), thru (informal).
  • Adds a few misspellings I've seen: callabck, cleand, notificaiton, seprated, serailze.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments from me.

Comment threadcodespell_lib/data/dictionary.txt Outdated
Comment threadcodespell_lib/data/dictionary.txt Outdated
@qyearsley

qyearsley commented Mar 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for review -- I still think it might be a good idea to consider including the names -- and also note, the dictionary already contains "tim->time, Tim, disabled due to being a person's name".

But if you feel that it's better to remove all mention of names and include misspellings that are also people's names, I could remove the names from this PR.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Comment threadcodespell_lib/data/dictionary.txt Outdated
Comment threadcodespell_lib/data/dictionary.txt Outdated
Comment threadcodespell_lib/data/dictionary.txt Outdated
@peternewman

Copy link
Copy Markdown
Collaborator

But if you feel that it's better to remove all mention of names and include misspellings that are also people's names, I could remove the names from this PR.

I'm merely another user, but the pragmatic solution may be to split the uncontentious non-name changes into another PR so they can be merged, while a consensus is potentially reached over what's in a name.

@qyearsleyqyearsley left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now removed names from this PR

Comment threadcodespell_lib/data/dictionary.txt Outdated
@qyearsley

Copy link
Copy Markdown
ContributorAuthor

Updated The idea in #103 is interesting; it seems like in general we could trend towards one more complicated dictionary, or multiple dictionaries/ignore-lists with more functionality

As-is, for my particular use case, I'm going to have to keep my own ignore list, although ignoring common proper nouns seems like a reasonable think to potentially include in codespell itself.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peternewman
peternewman merged commit 9a2361d into codespell-project:masterMar 6, 2020
@peternewman

Copy link
Copy Markdown
Collaborator

Thanks @qyearsley . Please open a new one with the other more "controversial" changes. And we'll see where #1437 goes too.

@peternewman

peternewman commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

@qyearsley we now have a solution. If you can add the names in a new PR to https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_names.txt would be great!

@qyearsley

Copy link
Copy Markdown
ContributorAuthor

Great news, good to know, thanks :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@qyearsley@peternewman