Uh oh!
There was an error while loading. Please reload this page.
Update dictionary with more misspellings and disabled names - #1425
Conversation
peternewman
left a comment
There was a problem hiding this comment.
A few comments from me.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Thanks for review -- I still think it might be a good idea to consider including the names -- and also note, the dictionary already contains But if you feel that it's better to remove all mention of names and include misspellings that are also people's names, I could remove the names from this PR. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
peternewman
commented
Mar 3, 2020
I'm merely another user, but the pragmatic solution may be to split the uncontentious non-name changes into another PR so they can be merged, while a consensus is potentially reached over what's in a name. |
qyearsley
left a comment
There was a problem hiding this comment.
Now removed names from this PR
Uh oh!
There was an error while loading. Please reload this page.
qyearsley
commented
Mar 3, 2020
Updated The idea in #103 is interesting; it seems like in general we could trend towards one more complicated dictionary, or multiple dictionaries/ignore-lists with more functionality As-is, for my particular use case, I'm going to have to keep my own ignore list, although ignoring common proper nouns seems like a reasonable think to potentially include in codespell itself. |
peternewman
left a comment
There was a problem hiding this comment.
LGTM, just one comment.
peternewman
commented
Mar 6, 2020
Thanks @qyearsley . Please open a new one with the other more "controversial" changes. And we'll see where #1437 goes too. |
@qyearsley we now have a solution. If you can add the names in a new PR to https://github.com/codespell-project/codespell/blob/master/codespell_lib/data/dictionary_names.txt would be great! |
qyearsley
commented
Apr 6, 2020
Great news, good to know, thanks :-) |
This PR: