Skip to content

Duplicated entry - #1478

Closed
Gelma wants to merge 3 commits into
codespell-project:masterfrom
Gelma:duplicated_entry
Closed

Duplicated entry#1478
Gelma wants to merge 3 commits into
codespell-project:masterfrom
Gelma:duplicated_entry

Conversation

@Gelma

@GelmaGelma commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

chache->cache
chached->cached
chacheline->cacheline
chack->check, chalk,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that needs catching in our tests.

que->queue
sargent->sergeant, argent,
tim->time
wen->when

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @qyearsley this is a name, if it's also in the main dictionary it needs removing from there.

sargent->sergeant, argent,
tim->time
wen->when
wight->weight, white, right, write,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pointed out Isle of Wight which I think this went in names.

See also these people:
https://en.wikipedia.org/wiki/Wight_(surname)

Perhaps we should split names into first and surname in terms of likelihood of clashes.

@peternewmanpeternewman added the dictionary Changes to the dictionary label Apr 10, 2020
@peternewman

Copy link
Copy Markdown
Collaborator

Hi @Gelma ,

#1501 now covers testing this and I've also fixed those issues I think, if you'd like to double-check as I see you added a few more bits too.

I've left Wen in names as it's a name, and chack in rare as it is technically a thing too.

Currently I've left Wight in rare as it's only a surname aside from the Isle of Wight, I guess we can see how we go with that.

Anyway if you'd like to update and either there will be no outstanding changes and this can be closed or it can be merged and closed.

@bl-uebl-ue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of this PR @Gelma?

@bl-uebl-ue closed this Jun 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionaryChanges to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Gelma@peternewman@bl-ue