Skip to content

Add several spelling corrections + fix some pre-existing - #1492

Closed
luzpaz wants to merge 2 commits into
codespell-project:masterfrom
luzpaz:turnk
Closed

Add several spelling corrections + fix some pre-existing#1492
luzpaz wants to merge 2 commits into
codespell-project:masterfrom
luzpaz:turnk

Conversation

@luzpaz

Copy link
Copy Markdown
Collaborator

No description provided.

Comment threadcodespell_lib/data/dictionary.txt Outdated
finialization->finalization
finializing->finalizing
finilizes->finalizes
finisch->finish, finish,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word finish is mentioned twice. Did you mean Finnish in one of the cases (language in Finland)?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was caught by the tests (although the error message isn't very clear):

assertlen(set(reps)) ==len(reps), 'entries are not (lower-case) unique'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message improved in #1493

@peternewmanpeternewmanApr 30, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in now, so would you mind doing a Git update first @luzpaz before you fix this, so I can confirm it worked fine in Travis before you commit the fix?

Edit, I realised I could test it another way, confirmed working here: https://travis-ci.org/github/peternewman/codespell/jobs/681564319#L570

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peternewman result: https://travis-ci.org/github/codespell-project/codespell/jobs/698171480#L738

E AssertionError: E error finisch: corrections "finish, finish," are not (lower-case) unique

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

Comment threadcodespell_lib/data/dictionary.txt Outdated
practicval->practical
practioner->practitioner
practioners->practitioners
practise->practice

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a typo:
https://en.wikipedia.org/wiki/Practice_(learning_method)

Possibly could go in the BE to AmE dictionary:

In English, practice is the noun and practise is the verb, but in American-English, the historically erroneous confusion of cases in America means it is now common for practice to be used both as a noun and a verb

Comment threadcodespell_lib/data/dictionary.txt Outdated
rabinnical->rabbinical
racaus->raucous
ractise->practise
ractise->practice

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change as above, although you could add ractice->practice too

Comment threadcodespell_lib/data/dictionary.txt Outdated
turle->turtle
turly->truly
turnk->turnkey, trunk,
turnk->trunk, turnkey,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also suggest turn.

@luzpaz

Copy link
Copy Markdown
CollaboratorAuthor

@peternewman

Copy link
Copy Markdown
Collaborator

Not sure what the problem is: https://travis-ci.org/github/codespell-project/codespell/jobs/698172331#L656

You've added:
ractise->practice

It's complaining that ractise isn't a valid word in Aspell, which doesn't surprise me. This correction doesn't need to be in this dictionary as you've already added practise->practice as I suggested.

@luzpaz

Copy link
Copy Markdown
CollaboratorAuthor

I'm confused since they look like separate typos to me? does aspell recognize ractise as a typo ?

@peternewman

Copy link
Copy Markdown
Collaborator

I'm confused since they look like separate typos to me? does aspell recognize ractise as a typo ?

The key thing is aspell doesn't recognise ractise as a valid word.

The GB to US dictionary is currently expected to consist of valid words on both sides (this slightly falls down as some more niche words, such as #1562, aren't in the dictionary). They should just be things like colour->color not coolour->color.

@luzpaz

luzpaz commented Oct 16, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Can we have a dictionary of non-recognizable aspell words then ?
Or we make an upstream push to aspell to add certain words ?

@luzpaz
luzpazforce-pushed the turnk branch 2 times, most recently from 220a052 to d2cfee3CompareNovember 20, 2020 17:32
publicised->publicized
publicises->publicizes
publicising->publicizing
ractise->practice

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think ractise is a real word, even in British English?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

practise is a real word and is the variant of practicebut the British and Australian spelling of it. ractise is just a typo of practise

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but the dictionary_en-GB_to_en-US.txt wants
valid Be->valid AE

you want to add the typo to the regular dictionary.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionaryChanges to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@luzpaz@peternewman@c72578@larsoner@sebweb3r@bl-ue