Uh oh!
There was an error while loading. Please reload this page.
Add flake8 annotions - #1502
Conversation
And no longer allow self-corrections within these checks (given we exclude them elsewhere already)
larsoner
commented
May 18, 2020
Seems to work nicely, now just need to fix the error |
peternewman
commented
May 18, 2020
This is ready for review, with one obvious fault so you can see it works! 🤣 |
peternewman
commented
May 18, 2020
Should be green now @larsoner so merge if you're happy. Sorry I missed you'd commented at exactly the same time as me before. I guess in future we might want to tune it to not annotate twice when it's within the main codespell repo somehow. |
larsoner
commented
May 18, 2020
I usually make all changes in my fork and open PRs. It's a better and more standard practice in my experience than making branches in the main repo |
peternewman
commented
May 18, 2020
Yeah I would do too normally if I was doing it properly via the CLI. Irritatingly GitHub takes that option away if you've got edit rights and you're just doing it lazily via the website. I just get:
Let me know if it's really bugging you though and I'll try and do the overhead to keep one of my branches in sync enough to make edits. |
larsoner
commented
May 18, 2020
No the branches are okay, just make sure to periodically remove them to ensure they don't accumulate. It's not great when people |
peternewman
commented
May 18, 2020
I'll just have to make sure I keep on top of the features then!
Yeah agreed. |
Via https://github.com/TrueBrain/actions-flake8
Blocked behind #1501 as I wanted some test failures!