Skip to content

Fix dictionary check action and standardise the make command we run - #1647

Merged
larsoner merged 30 commits into
masterfrom
peternewman-makefile-standardisation
Sep 1, 2020
Merged

Fix dictionary check action and standardise the make command we run#1647
larsoner merged 30 commits into
masterfrom
peternewman-makefile-standardisation

Conversation

@peternewman

@peternewmanpeternewman commented Aug 19, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@peternewman

peternewman commented Aug 19, 2020

Copy link
Copy Markdown
CollaboratorAuthor

This isn't catching the failure I thought it might. This fails:
https://github.com/codespell-project/codespell/runs/999123609?check_suite_focus=true

This doesn't:
https://github.com/codespell-project/codespell/runs/1003544298?check_suite_focus=true

But the equivalent Travis does.

Is it actually that pytest is missing or something?

@peternewman

peternewman commented Aug 28, 2020

Copy link
Copy Markdown
CollaboratorAuthor

It is indeed pytest:
https://github.com/codespell-project/codespell/runs/1039801917

@peternewmanpeternewman changed the title Standardise the make command we runFix dictionary check action and standardise the make command we runAug 28, 2020
peternewman
peternewman commented Aug 28, 2020
View reviewed changes
Comment thread.github/workflows/codespell-private.yml Outdated
peternewman
peternewman commented Aug 28, 2020
View reviewed changes
Comment threadMakefile Outdated
@peternewman
peternewman marked this pull request as ready for review August 28, 2020 04:19
@peternewmanpeternewman mentioned this pull request Aug 28, 2020
Merged
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Comment threadREADME.rst Outdated
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Comment threadREADME.rst Outdated
peternewmanand others added 2 commits September 1, 2020 04:25
@peternewman@larsoner
Update README.rst formatting
3ed624a
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@peternewman@larsoner
Tweak licence detail formatting
1cc9622
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes

@larsonerlarsoner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread.travis.yml Outdated
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Comment thread.travis.yml
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Comment thread.travis.yml Outdated
larsoner
larsoner reviewed Sep 1, 2020
View reviewed changes
Comment threadappveyor.yml Outdated
@larsoner
larsoner merged commit e4b648f into masterSep 1, 2020
@larsoner

larsoner commented Sep 1, 2020

Copy link
Copy Markdown
Member

Thanks @peternewman

@larsoner
larsoner deleted the peternewman-makefile-standardisation branch September 1, 2020 15:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsonerlarsonerAwaiting requested review from larsoner
1 more reviewer
@lurchlurchlurch left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@larsonerlarsoner

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peternewman@larsoner@lurch