Skip to content

Replacement of #1652 - #1663

Merged
peternewman merged 11 commits into
codespell-project:masterfrom
sebweb3r:lurch-patch-2
Sep 2, 2020
Merged

Replacement of #1652#1663
peternewman merged 11 commits into
codespell-project:masterfrom
sebweb3r:lurch-patch-2

Conversation

@sebweb3r

@sebweb3rsebweb3r commented Aug 30, 2020

Copy link
Copy Markdown
Contributor

Hijacking the MR of @lurch, since I cannot push into his branch

lurch
lurch reviewed Aug 31, 2020
View reviewed changes
Comment threadcodespell_lib/data/dictionary_code.txt Outdated
lurch
lurch reviewed Aug 31, 2020
View reviewed changes
Comment threadcodespell_lib/data/dictionary.txt Outdated
@lurch

lurch commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

Should I go ahead and close #1652 now?

@peternewman

peternewman commented Aug 31, 2020

Copy link
Copy Markdown
Collaborator

Should I go ahead and close #1652 now?

Yes please, as @sebweb3r seems to have pulled in all your commits.

@lurchlurch mentioned this pull request Aug 31, 2020
Closed
lurch
lurch reviewed Sep 2, 2020
View reviewed changes
Comment threadcodespell_lib/data/dictionary.txt
peternewman
peternewman requested changes Sep 2, 2020
View reviewed changes

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

Comment threadcodespell_lib/data/dictionary.txt
@lurch

lurch commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

Perhaps storys->stories, storeys, should be added too?

peternewman
peternewman approved these changes Sep 2, 2020
View reviewed changes

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@peternewman

peternewman commented Sep 2, 2020

Copy link
Copy Markdown
Collaborator

@lurch any more comments before I merge it?

@lurch

lurch commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

LGTM!

@peternewman
peternewman merged commit 008a66b into codespell-project:masterSep 2, 2020
@lurch

lurch commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

Thanks for taking this on @sebweb3r on my behalf 👍

@sebweb3r

sebweb3r commented Sep 2, 2020

Copy link
Copy Markdown
ContributorAuthor

you're welcome 👍

@sebweb3r
sebweb3r deleted the lurch-patch-2 branch September 2, 2020 23:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peternewmanpeternewmanpeternewman approved these changes
+1 more reviewer
@lurchlurchlurch left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebweb3r@lurch@peternewman