Skip to content

Add a few more en_GB -> en_US suggestions - #1666

Merged
peternewman merged 13 commits into
codespell-project:masterfrom
lurch:patch-2
Sep 22, 2020
Merged

Add a few more en_GB -> en_US suggestions#1666
peternewman merged 13 commits into
codespell-project:masterfrom
lurch:patch-2

Conversation

@lurch

Copy link
Copy Markdown
Contributor

No description provided.

Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
@lurchlurch mentioned this pull request Aug 31, 2020

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggestions

Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
@lurch

lurch commented Sep 2, 2020

Copy link
Copy Markdown
ContributorAuthor

I wonder if it'd be useful for the check-sorting step to point out all the mis-sorted words? Rather than just printing out the first error and then stopping, and not printing the second sorting error until after you've pushed a fix for the first sorting error.

@lurch

lurch commented Sep 2, 2020

Copy link
Copy Markdown
ContributorAuthor

According to the Travis check, neither customiser nor digitiser are in the aspell dictionary? 😕

@peternewman

Copy link
Copy Markdown
Collaborator

I wonder if it'd be useful for the check-sorting step to point out all the mis-sorted words? Rather than just printing out the first error and then stopping, and not printing the second sorting error until after you've pushed a fix for the first sorting error.

It probably would, but I'm not sure that's easily possible given we're just abusing sort, unless you wrote something more complicated around it with a while loop.

If you're doing it on a computer not via the website, then make sort-dictionaries is your friend, to correctly sort it.

@peternewman

Copy link
Copy Markdown
Collaborator

According to the Travis check, neither customiser nor digitiser are in the aspell dictionary? confused

The former should be fixed by #1485, the latter shows up the flaw with that and our dictionary work, as it's in the en_GB-large but not en_US-large dictionaries. Probably best dropping them for now and opening a new PR with just those two in.

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment.

Can you fix the conflicts too please.

Comment threadcodespell_lib/data/dictionary_en-GB_to_en-US.txt
@lurch

Copy link
Copy Markdown
ContributorAuthor

Done & done

@lurch

Copy link
Copy Markdown
ContributorAuthor

LOL, Travis is complaining about error 'authoriser' should be in aspell for dictionary /home/travis/build/codespell-project/codespell/codespell_lib/tests/../data/dictionary_en-GB_to_en-US.txt

Should I take it out again?

@sebweb3r

Copy link
Copy Markdown
Contributor

Yes, because otherwise all the test will fail forever!

@sebweb3r

sebweb3r commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

I cherry-picked it in #1626, so we can sort it sometimes in the far future 😄

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peternewman

Copy link
Copy Markdown
Collaborator

@sebweb3r are you happy?

@sebweb3r

Copy link
Copy Markdown
Contributor

Yes LGTM!

@peternewman
peternewman merged commit 14946a6 into codespell-project:masterSep 22, 2020
@lurch
lurch deleted the patch-2 branch September 22, 2020 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lurch@peternewman@sebweb3r