Uh oh!
There was an error while loading. Please reload this page.
Add a few more en_GB -> en_US suggestions - #1666
Conversation
Uh oh!
There was an error while loading. Please reload this page.
peternewman
left a comment
There was a problem hiding this comment.
A few more suggestions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lurch
commented
Sep 2, 2020
I wonder if it'd be useful for the check-sorting step to point out all the mis-sorted words? Rather than just printing out the first error and then stopping, and not printing the second sorting error until after you've pushed a fix for the first sorting error. |
lurch
commented
Sep 2, 2020
According to the Travis check, neither customiser nor digitiser are in the aspell dictionary? 😕 |
peternewman
commented
Sep 2, 2020
It probably would, but I'm not sure that's easily possible given we're just abusing sort, unless you wrote something more complicated around it with a while loop. If you're doing it on a computer not via the website, then |
peternewman
commented
Sep 2, 2020
The former should be fixed by #1485, the latter shows up the flaw with that and our dictionary work, as it's in the en_GB-large but not en_US-large dictionaries. Probably best dropping them for now and opening a new PR with just those two in. |
peternewman
left a comment
There was a problem hiding this comment.
One more comment.
Can you fix the conflicts too please.
Uh oh!
There was an error while loading. Please reload this page.
lurch
commented
Sep 21, 2020
Done & done |
lurch
commented
Sep 21, 2020
LOL, Travis is complaining about Should I take it out again? |
sebweb3r
commented
Sep 21, 2020
Yes, because otherwise all the test will fail forever! |
I cherry-picked it in #1626, so we can sort it sometimes in the far future 😄 |
peternewman
commented
Sep 22, 2020
@sebweb3r are you happy? |
sebweb3r
commented
Sep 22, 2020
Yes LGTM! |
No description provided.