Skip to content

Dedup->dedupe->deduplicate - #1672

Draft
peternewman wants to merge 42 commits into
codespell-project:mainfrom
peternewman:master
Draft

Dedup->dedupe->deduplicate#1672
peternewman wants to merge 42 commits into
codespell-project:mainfrom
peternewman:master

Conversation

@peternewman

Copy link
Copy Markdown
Collaborator

See also notes in #1602

peternewmanand others added 30 commits February 16, 2018 05:20
Real world ones, and equivalent variations thereof
@larsoner

Copy link
Copy Markdown
Member

Travis is not happy

@sebweb3r

Copy link
Copy Markdown
Contributor

Travis will never be happy with that. Informal requires both error and replacement to be in aspell. None of the three words is in aspell.
http://app.aspell.net/lookup?dict=en_US;words=dedup%0D%0Adedupe%0D%0Adeduplicate

@larsoner

Copy link
Copy Markdown
Member

Travis will never be happy with that. Informal requires both error and replacement to be in aspell. None of the three words is in aspell.

Travis will do whatever we say :) Concretely, I'm fine with modifying the test suite to have exceptions (# do not check aspell for this set of words) in cases like these if it's justified to do so

@sebweb3r

Copy link
Copy Markdown
Contributor

Ok, let me rephrase it. Without bending travis, it won't accept it.

This basically follows this trend:
#1711

@lurch

Copy link
Copy Markdown
Contributor

I suspect these commits need squashing? 😉

@bl-ue

Copy link
Copy Markdown
Contributor

@peternewman can I merge this PR? (SQUASH definitely!!)

@DimitriPapadopoulos

Copy link
Copy Markdown
Collaborator

@peternewman It should be possible to merge this pull request if you resolve the conflicts and put words missing from aspell under codespell_lib/tests/data.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dictionaryChanges to the dictionary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@peternewman@larsoner@sebweb3r@lurch@bl-ue@DimitriPapadopoulos