Add tests for aspell dictionaries different from 'en' by sebweb3r · Pull Request #1690 · codespell-project/codespell

sebweb3r · 2020-09-23T12:28:04Z

This adds additional tests in the en_GB-ise dictionary.

I can add en_CA and en_AU too

Closes#1689

lurch · 2020-09-23T13:49:49Z

I wonder if this PR would allow you to pull in any other words from #1626 ?

sebweb3r · 2020-09-23T13:56:43Z

Quick test said no. unfortunaly.

lurch · 2020-09-23T15:46:34Z

LOL, typo in your last comment 😆

EDIT: ... which isn't in dictionary.txt yet!

peternewman · 2020-09-23T15:55:55Z

EDIT: ... which isn't in dictionary.txt yet!

Well spotted and volunteered @lurch ! 😆

peternewman

Looks good, a few improvements that can be done.

sebweb3r · 2020-09-23T16:18:33Z

You know, those typos are the reason, why I'm here :-D

sebweb3r · 2020-09-23T17:40:34Z

@peternewman I need help. The github action and appveyor are failing, but travis and my debian are fine with the tests/commits. Any idea, why?

Edit: found it!

@lurch

Thanks to @lurch for improving my non-existing python skills

This behaves exactly like before. The tests will fail, since programme is not in en.

peternewman

A few comments and thoughts

lurch · 2020-10-02T21:58:33Z

Not that it really matters, but does the "Test: Change en_GB to en_GB-ise" commit-title have things the wrong way around?

sebweb3r · 2020-10-17T21:02:07Z

should work now like expected

sebweb3r · 2020-10-24T17:34:59Z

and @larsoner

larsoner

I didn't follow any of the discussion so let me know if there is some remaining issue. But looking at the code this looks good to me. @peternewman feel free to merge if you're happy

peternewman

A few comments

peternewman

A few more comments

peternewman

LGTM

This was referenced Sep 23, 2020
Dict: More words #1688
Merged
Some enGB words cause bugs with aspell #1689
Closed

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

peternewman requested changes Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated
Comment threadcodespell_lib/tests/test_dictionary.py Outdated
Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

sebweb3r commented Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Sep 23, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

sebweb3r added 13 commits September 24, 2020 11:54

Feat: Add enGB as dictionary for tests
1c5d47f

Test: rename speller2 to spellerGB
a2326fc

Test: Enhance code
ebe98a8
Thanks to @lurch for improving my non-existing python skills

Style: Add whitespace
0bf0466

Test: Build old functionality
777def3
This behaves exactly like before. The tests will fail, since programme is not in en.

Test: pass language through
9f70d73

Tests: Allow in_aspell to be list of dictionaries
a229608

Test: delete enAU and enCA
86e61e0

Test: log dictionaries that were tested
ab8c0cf

Test: try to fix ci
9835829

Test: Add suggestion
c248bed

Test: Add CA and AU again
eedad8a

Test: Flip output back
a44505d

peternewman requested changes Sep 24, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py
Comment threadcodespell_lib/_codespell.py Outdated
Comment threadcodespell_lib/_codespell.py Outdated
Comment threadcodespell_lib/_codespell.py Outdated

sebweb3r force-pushed the test_more_dicts branch from 53c364c to 42fcb9dCompare September 24, 2020 09:56

peternewman reviewed Sep 24, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

peternewman requested a review from larsoner September 24, 2020 10:00

sebweb3r added 2 commits September 24, 2020 12:04

Test: Fix typo
e77df81

Test: Change en_GB to en_GB-ise
60b905d

sebweb3r changed the title ~~Add tests for aspell en_GB-ise~~Add tests for aspell dictionaries different from 'en'Sep 24, 2020

sebweb3r force-pushed the test_more_dicts branch from fb7c064 to 60b905dCompare October 2, 2020 17:56

sebweb3r added 4 commits October 3, 2020 10:22

Test: Reintroduce language parameter
481b608

Style: Fix Flake8
120edee

Test: Fix all tests
e41384d

Style: Fix flake8
46276ee

sebweb3r requested a review from peternewman October 24, 2020 17:34

larsoner approved these changes Oct 26, 2020
View reviewed changes

sebweb3r mentioned this pull request Oct 26, 2020
Valid corrections that aren't in aspell/mainstream dictionaries #1711
Open

peternewman requested changes Oct 27, 2020
View reviewed changes

Comment threadcodespell_lib/_codespell.py Outdated
Comment threadcodespell_lib/_codespell.py Outdated
Comment threadcodespell_lib/tests/test_dictionary.py Outdated

sebweb3r added 2 commits October 27, 2020 14:35

Test: Add suggestion of@peternewman
266f450

Test: Fix output
62c12dc

lurch reviewed Oct 27, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

lurch reviewed Oct 27, 2020
View reviewed changes

Comment threadcodespell_lib/tests/test_dictionary.py Outdated

Test: Add suggestion of@lurch
1851f9c

peternewman requested changes Oct 27, 2020
View reviewed changes

Comment threadcodespell_lib/_codespell.py Outdated
Comment threadcodespell_lib/_codespell.py

Test: Remove more flake-stuff
d7852d8

sebweb3r mentioned this pull request Oct 27, 2020
Dict: Add complain* #1713
Merged

peternewman approved these changes Nov 3, 2020
View reviewed changes

peternewman merged commit c77fc5a into codespell-project:masterNov 3, 2020

sebweb3r deleted the test_more_dicts branch November 3, 2020 13:33

Uh oh!

Conversation

sebweb3r commented Sep 23, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lurch commented Sep 23, 2020

Uh oh!

sebweb3r commented Sep 23, 2020

Uh oh!

lurch commented Sep 23, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peternewman commented Sep 23, 2020

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebweb3r commented Sep 23, 2020

Uh oh!

sebweb3r commented Sep 23, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lurch commented Oct 2, 2020

Uh oh!

sebweb3r commented Oct 17, 2020

Uh oh!

sebweb3r commented Oct 24, 2020

Uh oh!

larsoner left a comment

Choose a reason for hiding this comment

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sebweb3r commented Sep 23, 2020•
edited
Loading

lurch commented Sep 23, 2020•
edited
Loading

sebweb3r commented Sep 23, 2020•
edited
Loading