Skip to content

MAINT: Ignore deliberate "adn" typo in README.rst - #1976

Closed
bl-ue wants to merge 2 commits into
masterfrom
skip-adn-readme-followup1535
Closed

MAINT: Ignore deliberate "adn" typo in README.rst#1976
bl-ue wants to merge 2 commits into
masterfrom
skip-adn-readme-followup1535

Conversation

@bl-ue

@bl-uebl-ue commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Followup to #1535

@bl-ue
bl-ue requested a review from peternewmanJune 14, 2021 19:49
@bl-ue

bl-ue commented Jun 14, 2021

Copy link
Copy Markdown
ContributorAuthor

@peternewman what about https://github.com/codespell-project/codespell/blob/skip-adn-readme-followup1535/.github/workflows/codespell.yml? Should I create a whole new GHA step for just the README? 🤔

@peternewman

peternewman commented Jun 14, 2021

Copy link
Copy Markdown
Collaborator

@peternewman what about https://github.com/codespell-project/codespell/blob/skip-adn-readme-followup1535/.github/workflows/codespell.yml? Should I create a whole new GHA step for just the README? thinking

I don't think you need to particularly, and it might confuse people somewhat if they go to use our action.

peternewman
peternewman requested changes Jun 14, 2021
View reviewed changes

@peternewmanpeternewman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to ignore .github/workflows/codespell-private.yml in .github/workflows/codespell.yml now. Or better yet explicitly differentiate between .git/* and .github/

Comment thread.github/workflows/codespell-private.yml Outdated
@bl-ue@peternewman
Update .github/workflows/codespell-private.yml
568c5a4
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
@bl-uebl-ue closed this Jan 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peternewmanpeternewmanpeternewman requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bl-ue@peternewman