Uh oh!
There was an error while loading. Please reload this page.
Tweak --ignore-regex to ignore consecutive matches - #2049
Open
peterjc wants to merge 2 commits into
Open
Conversation
peternewman
requested changes
Sep 14, 2021
peternewman
left a comment
Collaborator
There was a problem hiding this comment.
That makes sense thanks @peterjc .
Please can you add some tests for it so we won't regress in future (even if we change to a different workaround).
peterjc
commented
Sep 14, 2021
ContributorAuthor
I wasn't sure if this change was in the spirit of the original regex implementation, but since you like the idea, I agree a test or two is a good idea. |
peterjc
commented
Sep 14, 2021
ContributorAuthor
I've tested this locally now: Looks like the protective quotes are being lost somewhere in the test framework... |
Consider this example for 2 or 3 letter upper case words
(typical of acronyms):
```
codespell --ignore-regex '\W([A-Z]{2,3})\W'
```
If there are two consecutive matches in a string like
"text TE OTU text" only one gets removed - the problem
is the space needs to be used twice, the end of `` TE ``
and the start of `` OTU `` as the second but overlapping
regex match.peterjc
commented
Sep 14, 2021
ContributorAuthor
Solved, rather than doing what works at the command line, I needed to match what Python receives from the command line. Also rebased for a clearer history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this example for ignoring 2 or 3 letter upper case words (typical of acronyms):
If there are two consecutive matches in a string like "text TE OTU text" only one gets removed - the problem is the space needs to be used twice, the end of
TEand the start ofOTUas the second but overlapping regex match.Cross reference #1578.