Skip to content

ci: enable linters on changed code - #648

Merged
joka134 merged 13 commits into
mainfrom
ci/enable-more-linters
Aug 6, 2026
Merged

ci: enable linters on changed code#648
joka134 merged 13 commits into
mainfrom
ci/enable-more-linters

Conversation

@joka134

@joka134 joka134 commented Aug 6, 2026

Copy link
Copy Markdown
Member

This PR adds a new golangci-lint config that will help us to keep a more consistent style of code, which in the end helps us in code reviews and maintenance.
For now we still use the default settings when linting the whole repository (using .golangci-tmp.yml) and our target config (.golangci.yml) is only used on changed files (not only changed lines).

The target config is also the default config when using golangci during development. So I highly recommend setting golangci-lint v2 as default linter in vscode.

I also fixed two files as an example. I don't think fixing the findings takes too much time.
It's usually something like:

  • adding a package comment (default godoc style)
  • adding comments to exported functions (also godoc)
  • using a consistent whitespace style (not the one we all prefer probably, but at least the same for all 😄 )

The new linters in addition to the default settings are:

@joka134
joka134 marked this pull request as ready for review August 6, 2026 11:00
@joka134
joka134 marked this pull request as draft August 6, 2026 13:48
@joka134
joka134 force-pushed the ci/enable-more-linters branch from 413f2f7 to 45161f8 Compare August 6, 2026 13:52
@joka134
joka134 marked this pull request as ready for review August 6, 2026 13:53
@joka134
joka134 merged commit 47d8247 into main Aug 6, 2026
6 checks passed
@joka134
joka134 deleted the ci/enable-more-linters branch August 6, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants