ci: enable linters on changed code - #648
Merged
Merged
Conversation
Signed-off-by: joka134 <27293650+joka134@users.noreply.github.com>
joka134
marked this pull request as ready for review
August 6, 2026 11:00
NautiluX
approved these changes
Aug 6, 2026
joka134
marked this pull request as draft
August 6, 2026 13:48
joka134
force-pushed
the
ci/enable-more-linters
branch
from
August 6, 2026 13:52
413f2f7 to
45161f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new golangci-lint config that will help us to keep a more consistent style of code, which in the end helps us in code reviews and maintenance.
For now we still use the default settings when linting the whole repository (using
.golangci-tmp.yml) and our target config (.golangci.yml) is only used on changed files (not only changed lines).The target config is also the default config when using golangci during development. So I highly recommend setting golangci-lint v2 as default linter in vscode.
I also fixed two files as an example. I don't think fixing the findings takes too much time.
It's usually something like:
The new linters in addition to the default settings are: