Uh oh!
There was an error while loading. Please reload this page.
CPP compilation excludes redundant code submission file, fixes codewit-us/codewit.us#152 - #13
Conversation
| await compileCode('cxxtestgen', ['--error-printer', '-o', runnerCppPath, testHeaderPath], uniqueDir); | ||
| await compileCode('g++', ['-o', runnerExecutablePath, runnerCppPath, mainCppPath], uniqueDir); | ||
| await compileCode('g++', ['-std=c++20', '-o', runnerExecutablePath, runnerCppPath], uniqueDir); |
There was a problem hiding this comment.
program.cpp was removed from linking unconditionally. That fixes duplicate-symbol errors when tests #include "program.cpp", but it breaks extern-style tests (shown in README.md (line 104) and codeeval.http (line 38)) because student symbols are no longer linked.
Can we:
- Verify if all
testCodewill contain#include program.cpp?- If so, this should be okay, but there is still a compilation error due to executor.js that will auto-generate declarations from
program.cppand prepend them intotest_program.h. I think this might be injecting bad declarations and giving back wrong return types seen in @murthy-001's screenshot in Slack https://codewitus.slack.com/files/U08SNJSLWKU/F0AFCDLJ6PR/screenshot_2026-02-18_at_3.44.38___pm.png.
- If so, this should be okay, but there is still a compilation error due to executor.js that will auto-generate declarations from
- Update/align README.md and codeeval.http with the intended pattern(s) if something somewhere is incorrect?
There was a problem hiding this comment.
From a strategic standpoint, it's important that we let the user submit code that matches the video's code exactly and it should always pass the tests.
A secondary priority is that we want to avoid the system having to edit the user's submitted attempt (such as wrapping it in a novel namespace, deleting some code, or other workarounds) mostly because (A) it'd add more complexity and potential points of failure, and (B) compilation errors would likely report inconsistent line numbers with what the user actually submitted.
Therefore, it makes sense to put the burden on the test code for every exercise to adapt as necessary to test what was demonstrated in the video.
Can we [...] Verify if all testCode will contain #include program.cpp?
Yes. I'll make sure to document it for reference purposes, but this seems like our best solution. The test code will need to manipulate how program.cpp is processed (e.g. capture cin/cout to automate simulated console interaction, redefine main as program_main, etc.) so we'll need to adopt the practice of making sure to always #include program.cpp in the test file test_program.h
I've verified that the approach this PR takes fixes the compilation error when run manually within the codewit-us/containership/Dockerfile.cpp.box container. However, before merging it, we should verify that it works in local development with codeval + codewit.us
Update/align README.md and codeeval.http with the intended pattern(s) if something somewhere is incorrect?
Agreed, I'll update this PR with those revisions as well.
There was a problem hiding this comment.
PR #13 fixes the immediate duplicate-linking failure for include-style C++ tests by removing program.cpp from the runner link step, and I have confirmed that include-style payloads now pass locally.
Approving this as a scoped hotfix, with one suggested follow-up issue before/alongside rollout:
- Remove C++ declaration injection in
executor.js(the regex-generated declarations prepended totest_program.h) so test behavior is owned entirely bytestCode(#include "program.cpp,mainrenaming, I/O adaptation), since the current injection can still introduce signature conflicts (e.g., unsigned int vs int) and cause compile errors unrelated to student correctness.
Uh oh!
There was an error while loading. Please reload this page.
| await compileCode('cxxtestgen', ['--error-printer', '-o', runnerCppPath, testHeaderPath], uniqueDir); | ||
| await compileCode('g++', ['-o', runnerExecutablePath, runnerCppPath, mainCppPath], uniqueDir); | ||
| await compileCode('g++', ['-std=c++20', '-o', runnerExecutablePath, runnerCppPath], uniqueDir); |
There was a problem hiding this comment.
PR #13 fixes the immediate duplicate-linking failure for include-style C++ tests by removing program.cpp from the runner link step, and I have confirmed that include-style payloads now pass locally.
Approving this as a scoped hotfix, with one suggested follow-up issue before/alongside rollout:
- Remove C++ declaration injection in
executor.js(the regex-generated declarations prepended totest_program.h) so test behavior is owned entirely bytestCode(#include "program.cpp,mainrenaming, I/O adaptation), since the current injection can still introduce signature conflicts (e.g., unsigned int vs int) and cause compile errors unrelated to student correctness.
Trying to compile
runner.cppandprogram.cppresults in function redefinition errors sinceprogram.cppis already included when the previouscxxtestgencommand is run.Please check this PR thoroughly because this is a quick patch that I have not given due diligence to testing, but I wanted to offer the fix while it's fresh on my mind.