Skip to content

chore: add volunteer AldrinSeanPereira - #79

Open
grbz378 wants to merge 7 commits into
codewithvoid:mainfrom
grbz378:patch-1
Open

chore: add volunteer AldrinSeanPereira#79
grbz378 wants to merge 7 commits into
codewithvoid:mainfrom
grbz378:patch-1

Conversation

@grbz378

Copy link
Copy Markdown

I'd like to make my first PR with this wonderful project!

@vercel

vercelBot commented Nov 30, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
ask-devs✅ Ready (Inspect)Visit PreviewDec 25, 2022 at 10:30AM (UTC)

Comment threaddata/users/AldrinSeanPereira.json Outdated
{
"name": "Aldrin Sean Pereira",
"bio": "Software Engineer",
"image": "",

@RakeshSangemRakeshSangemNov 30, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey you missed the image URL.

Here is your GitHub's avatar URL https://avatars.githubusercontent.com/u/54813708?v=4 you can use it.

Comment threaddata/users/AldrinSeanPereira.json Outdated
"image": "",
"categories": [
{
"slug": "programming | software-development",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one slug should be added!

Comment threaddata/users/AldrinSeanPereira.json Outdated
"categories": [
{
"slug": "programming | software-development",
"topics": []

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add topics which you are good at like javascript or python

@codewithvoid

Copy link
Copy Markdown
Owner

Thanks for volunterring @AldrinSeanPereira :). PTAL at @RakeshSangem's comments.

@codewithvoidcodewithvoid changed the title Create AldrinSeanPereira.jsonchore: add volunteer AldrinSeanPereiraDec 1, 2022

@grbz378grbz378 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected my PR. Thanks to the reviewers for taking the time to help!!
@RakeshSangem@codewithvoid

Comment threaddata/users/AldrinSeanPereira.json Outdated
{
"name": "Aldrin Sean Pereira",
"bio": "Software Engineer",
"image": "C:\Users\admin\Downloads\20220704_154207.jpg",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use github image url here like

https://avatars.githubusercontent.com/u/54813708?v=4

Comment threaddata/users/AldrinSeanPereira.json Outdated
Comment threaddata/users/AldrinSeanPereira.json Outdated
@codewithvoid

Copy link
Copy Markdown
Owner

@AldrinSeanPereira added small comments. PTAL.

@grbz378

Copy link
Copy Markdown
Author

got it. thank you @codewithvoid 🥰❤️

specified only programming languages

@grbz378grbz378 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes made according to @codewithvoid's suggestions :)

"image": "https://avatars.githubusercontent.com/u/54813708?v=4",
"categories": [
{
"slug": "software-development",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to programming

"categories": [
{
"slug": "software-development",
"topics": [C, C#, Python]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be in quotes to be in valid json

"topics": ["C", "C#", "Python"]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@grbz378@codewithvoid@RakeshSangem