Uh oh!
There was an error while loading. Please reload this page.
Add lib64 dir as a lib directory with -L if it exists - #62
Conversation
| @property | ||
| def deps_lib(self): | ||
| def deps_lib_dir(self): | ||
| return self.deps / "lib" |
There was a problem hiding this comment.
This leads to a lot of places to adapt with previous PR #59 because self.deps_lib is used quite a bit from c_configure_args().
I'll try and get my hands on a Centos7 instance (or Rocky9?) to try and see what's up with the lib64 thing.
I was also able to use the system libffi internally, so the need to statically compile libffi is gone for me. Ideally it would absolutely keep working of course, it's just that I haven't had to directly deal with it.
Try and merge main here to see what to do with the deps_lib -> deps_lib_dir rename. The rename may be actually helpful (will help spot out missed places that weren't adapted)
Uh oh!
There was an error while loading. Please reload this page.
| yield from os.environ.get("PKG_CONFIG_PATH", "").split(":") | ||
| if self.modules.selected: | ||
| yield f"{self.deps_lib}/pkgconfig" | ||
| yield f"{self.deps_lib_dir}/pkgconfig" |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| yield f"--with-tcltk-libs=-L{self.deps_lib} -ltcl{version.mm} -ltk{version.mm}" | ||
| lib_dir_flags = " ".join(f"-L{lib_dir}" for lib_dir in self.deps_lib_dirs) | ||
| yield f"--with-tcltk-libs={lib_dir_flags} -ltcl{version.mm} -ltk{version.mm}" |
There was a problem hiding this comment.
Hmm, I'm having a doubt here... usually I yield one item at a time... wonder if that's what make tkinter so iffy (it's hard to include/compile actually).
Knowing how the code usually operates, this should be yielding one string per (instead of space separated string)... Wonder why I had spaces in there. Should be more like:
yield f"--with-tcltk-libs={lib_dir_flags}"
yield f"-ltcl{version.mm}"
yield f"-ltk{version.mm}"
solvingj
commented
Feb 14, 2025
Thanks for reviewing, I believe I've resolved all the issues. |
zsimic
commented
Feb 14, 2025
Looks good to me |
Closes#47
In conjunction with #59 and #60 , these changes enabled us to compile in openssl 3.0.15 into python 3.12.3 on ubuntu 18.04.