Fix class to show bookmarks colours - #1177

Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged

Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom
CarolinaCobo:fix-bookmarks

Conversation

@CarolinaCobo

@CarolinaCoboCarolinaCobo commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

✨ Codu Pull Request 💻

Fixes #(issue)

Pull Request details

  • Bookmark and like icons weren't displaying the colours when clicked.

Any Breaking changes

None

Associated Screenshots

@CarolinaCobo
CarolinaCobo requested a review from a team as a code ownerOctober 25, 2024 16:26
@vercel

vercelBot commented Oct 25, 2024

Copy link
Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitaiBot commented Oct 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.

Changes

FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.

Possibly related PRs

Suggested reviewers

  • NiallJoeMaher
  • John-Paul-Larkin

Poem

In the menu, icons gleam,
With heights and widths, they team.
A popover now shows with grace,
Clipboard checks keep pace.
Hopping through code, we cheer,
For UI changes, oh so dear! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitaiBot reviewed Oct 25, 2024
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)

Line range hint 52-69: Consider improving error handling for like/bookmark actions.

The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.

Here's a suggested implementation:

 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};

Note: You'll need to import a toast notification library of your choice.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 051f633 and b7b6ff0.

📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)

Line range hint 142-147: LGTM! HeartIcon styling is correct.

The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.

Line range hint 165-170: LGTM! BookmarkIcon styling is correct.

The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.

@vercel

vercelBot commented Oct 25, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm

NiallJoeMaher
NiallJoeMaher approved these changes Oct 25, 2024
View reviewed changes

@NiallJoeMaherNiallJoeMaher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖

@NiallJoeMaher
NiallJoeMaher merged commit 871253f into codu-code:developOct 25, 2024
This was referenced Oct 25, 2024
Merged
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Nov 4, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees

No one assigned

Labels

hacktoberfesthacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix class to show bookmarks colours - #1177
Merged
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Oct 25, 2024
Merged
Fix class to show bookmarks colours#1177
NiallJoeMaher merged 1 commit into
codu-code:developfrom 
CarolinaCobo:fix-bookmarks
Conversation
@CarolinaCobo
@CarolinaCoboCarolinaCobo
commented
Oct 25, 2024

Copy link


Copy Markdown

Contributor
✨ Codu Pull Request 💻
Fixes #(issue)
Pull Request details
  • Bookmark and like icons weren't displaying the colours when clicked.
Any Breaking changes
None
Associated Screenshots
@CarolinaCobo
CarolinaCobo
requested a review
from a team
as a code ownerOctober 25, 2024 16:26
@vercel
vercelBot
commented
Oct 25, 2024

Copy link


Copy Markdown

@CarolinaCobo is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
@coderabbitai
coderabbitaiBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
The pull request includes modifications to the ArticleMenu and ArticlePreview components, primarily focusing on the styling of the HeartIcon and BookmarkIcon components. The order of the width and height classes for these icons has been switched. Additionally, the PopoverPanel className in ArticleMenu has been updated to conditionally render based on its open state. The clipboard interaction logic has been refined to prevent copying under certain conditions. Overall, the changes enhance the UI behavior and interaction logic without introducing new functionalities.
Changes
FileChange Summary
components/ArticleMenu/ArticleMenu.tsx- Updated HeartIcon and BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- Adjusted PopoverPanel className to conditionally apply "hidden" based on isPopoverPanelOpen state.
- Modified handleCopyToClipboard to prevent copying if button label does not match innerHTML.
components/ArticlePreview/ArticlePreview.tsx- Updated BookmarkIcon className order from w-6 h-6 to h-6 w-6.
- No changes to logic or functionality.
Possibly related PRs
Suggested reviewers
  • NiallJoeMaher
  • John-Paul-Larkin
Poem
In the menu, icons gleam,

With heights and widths, they team.

A popover now shows with grace,

Clipboard checks keep pace.

Hopping through code, we cheer,

For UI changes, oh so dear! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:

    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:

    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:

    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.
Other keywords and placeholders
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
coderabbitai[bot]
coderabbitaiBot
reviewed
Oct 25, 2024
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/ArticleMenu/ArticleMenu.tsx (1)
Line range hint 52-69: Consider improving error handling for like/bookmark actions.
The error handling is currently limited to console logging. Consider adding user feedback for failed actions to improve the user experience.
Here's a suggested implementation:
 const likePost = async (postId: string, setLiked = true) => {
if (likeStatus === "loading") return;
try {
await like({ postId, setLiked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to like post:', err);+ // Show user feedback+ toast.error('Failed to like post. Please try again.');
}
};
const bookmarkPost = async (postId: string, setBookmarked = true) => {
if (bookmarkStatus === "loading") return;
try {
await bookmark({ postId, setBookmarked });
} catch (err) {
- // @TODO handle error- console.error(err);+ console.error('Failed to bookmark post:', err);+ // Show user feedback+ toast.error('Failed to bookmark post. Please try again.');
}
};
Note: You'll need to import a toast notification library of your choice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between 051f633 and b7b6ff0.
📒 Files selected for processing (2)
  • components/ArticleMenu/ArticleMenu.tsx (2 hunks)
  • components/ArticlePreview/ArticlePreview.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/ArticlePreview/ArticlePreview.tsx
🔇 Additional comments (2)
components/ArticleMenu/ArticleMenu.tsx (2)
Line range hint 142-147: LGTM! HeartIcon styling is correct.
The conditional color styling properly shows red for liked state and neutral for unliked state, which aligns with the PR objective.
Line range hint 165-170: LGTM! BookmarkIcon styling is correct.
The conditional color styling properly shows blue for bookmarked state and neutral for unbookmarked state, which directly addresses the PR objective.
@vercel
vercelBot
commented
Oct 25, 2024•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
NameStatusPreviewCommentsUpdated (UTC)
codu✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 25, 2024 5:51pm
NiallJoeMaher
NiallJoeMaher
approved these changes
Oct 25, 2024
View reviewed changes
@NiallJoeMaherNiallJoeMaher
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖
@NiallJoeMaher
NiallJoeMaher
merged commit 871253f
into
codu-code:developOct 25, 2024

This was referenced Oct 25, 2024
 Merged

 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Nov 4, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@NiallJoeMaherNiallJoeMaherNiallJoeMaher approved these changes

Assignees


No one assigned


Labels

hacktoberfesthacktoberfest-accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@CarolinaCobo@NiallJoeMaher