Skip to content

Remove extraneous pattern match on:exec.stop/1 call - #9

Merged
nsweeting merged 1 commit into
mainfrom
fix/handle-kill-command-errors
Aug 26, 2025
Merged

Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom
fix/handle-kill-command-errors

Conversation

@ethunk

@ethunkethunk commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.

This change removes the extraneous pattern match and allows the rest of the code to complete.

We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.
Example error:

https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6

https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336

There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.

The two stacktraces:

GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And

** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491

try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.

@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed the fix/handle-kill-command-errors branch from f6ac49f to 10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk changed the title Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk changed the title Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk changed the title Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting merged commit 2aa9b42 into mainAug 26, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove extraneous pattern match on`:exec.stop/1` call by ethunk · Pull Request #9 · coherentpath/vector_agent · GitHub
Skip to content
Remove extraneous pattern match on:exec.stop/1 call - #9
Merged
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Aug 26, 2025
Merged
Remove extraneous pattern match on:exec.stop/1 call#9
nsweeting merged 1 commit into
mainfrom 
fix/handle-kill-command-errors
Conversation
@ethunk
@ethunkethunk
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Fixes MatchError when kill command fails during process termination. The exec.stop(<pid>) call is returning {:error, ~c"pid not alive"} and fails the pattern match.
This change removes the extraneous pattern match and allows the rest of the code to complete.
We've seen ~16k cases of this error in the last 30 days across the STG and DEV environment.

Example error:
https://cloudlogging.app.goo.gl/qeXsYrDo4WrLUabs6
https://movable-ink.sentry.io/organizations/movable-ink/issues/6751271449/?environment=prod&project=4508808170766336
There are actually two different errors that are happening inside of the vector code and I think that this will solve both of them.
The two stacktraces:
GenServer #PID<0.151748.0> terminating
** (stop) :enoent
(elixir 1.18.0) lib/system.ex:1114: System.cmd("kill", ["-0", "22842"], [stderr_to_stdout: true])
(vector_agent 0.3.3) lib/vector/agent.ex:145: Vector.Agent.do_confirm_exit/1
(vector_agent 0.3.3) lib/vector/agent.ex:93: Vector.Agent.terminate/2
(stdlib 6.2) gen_server.erl:2393: :gen_server.try_terminate/3
(stdlib 6.2) gen_server.erl:2594: :gen_server.terminate/10
(stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: :shutdown

And
** (MatchError) no match of right hand side value: {:error, ~c"pid not alive"}
(vector_agent 0.3.3) lib/vector/agent.ex:92:in `Vector.Agent.terminate/2'
(stdlib 6.2) gen_server.erl:2393:in `:gen_server.try_terminate/3'
(stdlib 6.2) gen_server.erl:2594:in `:gen_server.terminate/10'
(stdlib 6.2) proc_lib.erl:329:in `:proc_lib.init_p_do_apply/3'

The first error occurs when the :gen_server.try_terminate/3 is called, this is defined https://github.com/erlang/otp/blob/master/lib/stdlib/src/gen_server.erl#L2478-L2491
try_terminate(#server_data{module = Mod}, State, Reason) ->
case erlang:function_exported(Mod, terminate, 2) of
true ->
try
{ok, Mod:terminate(Reason, State)}
catch
throw:R ->
{ok, R};
Class:R:Stacktrace ->
{'EXIT', Class, R, Stacktrace}
end;
false ->
{ok, ok}
end.

The error is being generated by the Mod:terminate(Reason, State) function call which is actually a call back out to the agents terminate command Vector.Agent.terminate/2, which fails with the pattern match and is returned by the calling process.
@ethunk
Remove pattern match on calling exec.stop/1
10fd2a0
There is no need to pattern match on this function call. We check to
confirm that the process was stopped correctly in the next line. With
the current pattern match, we cause an error when the PID is already
stopped.
@ethunk
ethunkforce-pushed
the
fix/handle-kill-command-errors
branch
from
f6ac49f to
10fd2a0CompareAugust 25, 2025 21:33
@ethunkethunk
changed the title
Handle System.cmd error case in do_confirm_exit functionRemove extraneous pattern match on Exec call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on Exec call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorAug 25, 2025
@ethunkethunk
changed the title
Remove extraneous pattern match on:exec.stop/1 call to needlessly raising an errorRemove extraneous pattern match on:exec.stop/1 callAug 25, 2025
@nsweeting
nsweeting
merged commit 2aa9b42
into
mainAug 26, 2025

2 checks passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nsweetingnsweetingnsweeting approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ethunk@nsweeting