feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat: add Aerodrome Finance action provider - #1038

Open
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider
Open

feat: add Aerodrome Finance action provider#1038
vijaygopalbalasa wants to merge 1 commit into
coinbase:mainfrom
vijaygopalbalasa:feat/aerodrome-action-provider

Conversation

@vijaygopalbalasa

Copy link
Copy Markdown

Overview

Adds an Aerodrome Finance action provider for Base mainnet — the #1 DEX on Base by TVL (~$400M+, ~56% of Base trading volume). Covers the full user flow: trading, liquidity provision, veAERO governance locking, voting, lock management, and reward claiming.

Actions (10)

Trading

ActionDescription
aerodrome_get_quoteGet a swap quote for a token pair (read-only)
aerodrome_swapSwap tokens with slippage protection via on-chain quote

Liquidity

ActionDescription
aerodrome_add_liquidityAdd liquidity to a pool (uses quoteAddLiquidity for slippage)
aerodrome_remove_liquidityRemove liquidity (uses quoteRemoveLiquidity for slippage)

Governance (veAERO)

ActionDescription
aerodrome_create_lockLock AERO tokens to create a veAERO NFT
aerodrome_voteVote with veAERO NFT to direct pool emissions
aerodrome_increase_amountAdd more AERO to an existing lock
aerodrome_increase_unlock_timeExtend lock duration
aerodrome_withdrawWithdraw AERO from an expired lock

Rewards

ActionDescription
aerodrome_claim_rewardsClaim trading fees and bribes (separate token arrays)

Files

typescript/agentkit/src/action-providers/aerodrome/
├── aerodromeActionProvider.ts # 10 actions, ~940 lines
├── aerodromeActionProvider.test.ts # 62 tests, ~770 lines
├── constants.ts # ABIs (Router, VotingEscrow, Voter) + addresses
├── schemas.ts # Zod schemas with validation + descriptions
├── index.ts # Barrel export
└── README.md # Documentation

Also modified:

  • typescript/agentkit/src/action-providers/index.ts — added aerodrome export
  • typescript/agentkit/README.md — added Aerodrome to Action Providers list (alphabetical)

Key Design Decisions

Slippage protection: All swap and liquidity actions use slippageBps (default 1%, max 10%) instead of raw amountOutMin. The provider calls getAmountsOut, quoteAddLiquidity, or quoteRemoveLiquidity on-chain to get expected amounts, then applies the slippage tolerance. This is what @phdargen suggested in the review of #672.

Token details via multicall: Reuses getTokenDetails from erc20/utils.ts for efficient batched token info + balance fetching, as suggested in #672 review.

veAERO tokenId extraction: Parses the Deposit event log from createLock transactions, filtered by log.address === VOTING_ESCROW_ADDRESS, to return the minted NFT's token ID for use in subsequent vote calls.

Pre-flight safety checks: Every veAERO-mutating action verifies NFT ownership via ownerOf before sending transactions. vote additionally checks voting power > 0 and epoch status via lastVoted. increaseUnlockTime checks for expired locks, permanent locks, and the 4-year ceiling. withdraw checks lock expiry and permanent status.

Separate fee/bribe token arrays: claimRewards takes feeTokens (pool underlying tokens) and bribeTokens (protocol incentives) as separate parameters, since fee contracts and bribe contracts hold different tokens.

Lock duration math: increaseUnlockTime correctly computes totalDurationFromNow = remainingSeconds + additionalSeconds because the VotingEscrow contract interprets _lockDuration as duration from block.timestamp, not a delta from the current lock end.

Testing

62 tests covering all actions and code paths:

getQuote: 5 tests (success, stable pool, zero output, null tokens, RPC error)
swap: 6 tests (success, null tokens, insufficient balance, zero output, approval fail, tx error)
addLiquidity: 7 tests (success, null tokens, insufficient A, insufficient B, approval A fail, approval B fail, tx error)
removeLiquidity: 5 tests (success, null LP, insufficient LP, approval fail, tx error)
createLock: 7 tests (success with log parsing, empty logs, wrong address filter, null AERO, insufficient balance, approval fail, tx error)
vote: 8 tests (success, multi-pool weights, not owner, zero power, already voted, previous epoch allowed, second pool no gauge, tx error)
increaseAmount: 4 tests (success, not owner, insufficient balance, approval fail)
increaseUnlockTime: 5 tests (success, not owner, permanent lock, expired lock, exceeds 4yr max)
withdraw: 5 tests (success, not owner, not expired, permanent, tx error)
claimRewards: 6 tests (success, fees fail/bribes pass, fees pass/bribes fail, both fail, not owner, no gauge)
supportsNetwork: 4 tests (base-mainnet, base-sepolia, ethereum, non-EVM)

Test plan

  • pnpm --filter @coinbase/agentkit build — compiles clean
  • jest --testPathPattern="src/action-providers/aerodrome" — 62/62 pass
  • Zero console.log in source files
  • All 22 ABI entries verified against deployed Aerodrome contracts on BaseScan
  • All 5 contract addresses verified active on Base mainnet (March 2026)
  • README entry added to typescript/agentkit/README.md (alphabetical order)
  • CI pipeline validation

Adds a complete Aerodrome Finance integration for Base mainnet with
10 actions covering trading, liquidity, veAERO governance, and rewards.
Actions:
- aerodrome_get_quote: swap quote (read-only)
- aerodrome_swap: token swap with slippage protection
- aerodrome_add_liquidity: LP deposit with quoteAddLiquidity
- aerodrome_remove_liquidity: LP withdrawal with quoteRemoveLiquidity
- aerodrome_create_lock: lock AERO -> veAERO NFT (extracts tokenId from logs)
- aerodrome_vote: vote on pool emissions (ownership + epoch checks)
- aerodrome_increase_amount: add AERO to existing lock
- aerodrome_increase_unlock_time: extend lock duration
- aerodrome_withdraw: withdraw from expired lock
- aerodrome_claim_rewards: claim fees + bribes (separate token arrays)
Design:
- Slippage-based swap/LP (default 1%, max 10%) via on-chain quotes
- Reuses getTokenDetails from erc20/utils for multicall efficiency
- Pre-flight checks: NFT ownership, voting power, epoch status,
lock expiry, permanent lock, 4-year ceiling
- Deposit event log parsing filtered by contract address
- 62 tests covering all code paths
Resolves WISHLIST.md items: Aerodrome veAERO lock, liquidity pool voting.
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation action provider New action provider typescript labels Mar 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action providerNew action providerdocumentationImprovements or additions to documentationtypescript

Development

Successfully merging this pull request may close these issues.

2 participants

@vijaygopalbalasa@cb-heimdall