Uh oh!
There was an error while loading. Please reload this page.
feat: add Enso route action - #160
Conversation
✅ Heimdall Review Status
|
murrlincoln
commented
Jan 24, 2025
Awesome, thank you for submitting this! Taking a look from our end and will respond with some recommended changes |
John-peterson-coinbase
commented
Feb 10, 2025
@Brenzee - the 0.1.0 release refactors the package into the Action/Wallet Provider pattern. Please rebase and update and we will be happy to accept 🚀 |
phdargen
commented
Sep 16, 2025
Hi @Brenzee, thanks for your contribution! This is very useful and would be a great addition, sorry for the delay If you are still interested in working on this, please rebase against main and bump the ensofinance/sdk version, then I will do some manual testing A few initial comments below |
Uh oh!
There was an error while loading. Please reload this page.
phdargen
commented
Sep 16, 2025
Note that we require signed commits. See here for instructions on setting up commit signing. Once setup, rebase against main to re-sign all commits |
phdargen
commented
Sep 16, 2025
Please add entry in agentkit/README (https://github.com/coinbase/agentkit/blob/main/typescript/agentkit/README.md), should follow alphabetic order and add a README in action-providers/enso (see other actions as example) |
phdargen
commented
Sep 16, 2025
Please add a changelog as described in https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog |
Uh oh!
There was an error while loading. Please reload this page.
Brenzee
commented
Sep 22, 2025
hey @phdargen , I appreciate all your suggestions and comments! |
Hi @Brenzee, thanks a lot for the update! Looks good, but I have a few more follow-ups after manual testing the action. Also please add a README in action-providers/enso similar to what we have for other actions |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Half of the tests are failing, please have a look: Enso Route Schema |
phdargen
commented
Sep 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
Brenzee
commented
Sep 23, 2025
hey @phdargen , apologies about that! |
phdargen
commented
Sep 24, 2025
Oh I see, sorry for not spotting this earlier. We should not make real API calls here as tests might fail due to network issues, API rate limits or service outages. |
phdargen
commented
Sep 24, 2025
Hi @Brenzee, thanks for the prompt updates! The changes look good but the tests still need some work, please let me know if you have any questions |
Brenzee
commented
Sep 24, 2025
i followed |
phdargen
commented
Sep 25, 2025
Great, that should be all! Thanks again for your contribution |
phdargen
commented
Sep 25, 2025
This is tested and good to go @CarsonRoscoe |
What changed? Why?
enso_routethat utilizes Enso APIQualified Impact
Changes to
cdp-agentkit-core/typescript