feat: viem signing hex or uint8array

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe

[azf20]

What changed?

Allowed passing of a "hex" or bytes to "signMessage" for Viem & Viem-derived Wallet Providers

Why was this change implemented?

Currently Viem signing only supports strings. Viem itself can support Uint8Array & Hex (code, docs).

As the evmWalletProvider doesn't support the { raw: <input> }, we cast everything to a hex string based on the following logic and pass it into raw:

 const hexMessage =
typeof message === "string" ? (isHex(message) ? message : toHex(message)) : message;
return this.#walletClient.signMessage({
account,
message: { raw: hexMessage },
});

This is to enable signing Hex messages as well as bytes (e.g. transaction hashes - this came up while trying to sign Gnosis Safe messages) - which otherwise get "hex'd" again by Viem when passed as string messages.

cc @escottalexander

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 2 if repo is sensitive 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[CarsonRoscoe]

Hey @azf20, apologies for letting this go stale.

I agree with this PR. If you rebase against main and ping me, I'll review and aim to get this in for release.

Thank you for the contribution!

[azf20]

No problem, I rebased. Thanks for taking a look!

[phdargen]

Looks good to me, thanks @azf20! Could you please add a changelog (https://github.com/coinbase/agentkit/blob/main/CONTRIBUTING-TYPESCRIPT.md#changelog), then this can be merged imo

[azf20]

Added, thanks!

[phdargen]

This is good to go @CarsonRoscoe