Uh oh!
There was an error while loading. Please reload this page.
Conversation
✅ Heimdall Review Status
|
| * @returns True if the Pyth action provider supports the network, false otherwise. | ||
| */ | ||
| supportsNetwork = () => true; | ||
| supportsNetwork = (network: Network) => network.protocolFamily === "evm"; |
Contributor
There was a problem hiding this comment.
pyth is not EVM specific
| supportsNetwork(): boolean { | ||
| return true; | ||
| supportsNetwork(network: Network): boolean { | ||
| return network.protocolFamily === "evm"; |
Contributor
There was a problem hiding this comment.
I believe alchemy price data works with Solana as well? Please confirm
0xRAGforce-pushed
the
AGENT-202
branch
2 times, most recently
from
February 20, 2025 13:11
8302e64 to
beedb2fCompareJohn-peterson-coinbase
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why was this change implemented?
A lot of the action providers have a naive filter for network:
This breaks down now that we have support for Solana.
This PR:
Checklist
How has it been tested?
Tested with agent by adding these lines to the privy chatbot:
Before:
After:
Example of warning:
Setup: Solana Chatbot, importing weth and erc20 action providers: