Uh oh!
There was an error while loading. Please reload this page.
feat: add zeroDevWalletProvider - #665
Conversation
✅ Heimdall Review Status
|
cb-heimdall
commented
Apr 9, 2025
🟡 Heimdall Review Status
|
| * @param config - The configuration options for the ZeroDevWalletProvider. | ||
| * @returns A Promise that resolves to a new ZeroDevWalletProvider instance. | ||
| */ | ||
| public static async configureWithSigner( |
There was a problem hiding this comment.
nit: Our convention is to call this configureWithWallet, please update this to such
CarsonRoscoe
left a comment
There was a problem hiding this comment.
There is a table int he section ## Action Providers in the file /typescript/agentkit/README.md. Please add a new table entry for Zero Dev.
Note: Entries are in alphabetical order
| }); | ||
| // Create a Viem account from the EVM wallet provider | ||
| const address = config.signer.getAddress() as `0x${string}`; |
There was a problem hiding this comment.
nit: Please replace all 0x${string} with either Address or Hex (whichever is more appropriate) from Viem
| /** | ||
| * The network of the wallet. | ||
| */ | ||
| network: Network; |
There was a problem hiding this comment.
Your taking the entire network object, which requires that the calling user have the domain knowledge to set everything up. We prefer to minimize the caller's knowledge requirement, and handle defaults.
Please update this param into two optional params, networkId?: string and chainId?: string
| this.#signer = config.signer; | ||
| this.#projectId = config.projectId; | ||
| this.#network = config.network; |
There was a problem hiding this comment.
Please assign a #network as such:
const networkId = config.networkId || "base-sepolia";
const chainId = config.chainId || NETWORK_ID_TO_CHAIN_ID[networkId];
this.#network = {
protocolFamily: "evm",
networkId: networkId,
chainId: chainId,
};
| */ | ||
| async sendTransaction(transaction: TransactionRequest): Promise<`0x${string}`> { | ||
| // Get the chain ID from the network | ||
| const chainId = parseInt(this.#network.chainId || "1"); |
There was a problem hiding this comment.
nit: since we now do the network assignment in a way that guarantees chainId, replace the || "1" fallback with a !
| * | ||
| * @returns The underlying signer. | ||
| */ | ||
| // getSigner(): EvmWalletProvider { |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Your solution to creating a signer out of a EvmWalletProvider is very elegant. I would like to promote this logic to EvmWalletProvider as a helper function toSigner() which returns a Viem signer.
Then, update your action provider to take a viem signer. Callers will be expected to toSigner() their provider before passing it in.
| }; | ||
| cdpWalletProvider = evmWalletProvider = | ||
| await CdpWalletProvider.configureWithWallet(cdpConfig); | ||
| console.log(`CDP Wallet Address: ${evmWalletProvider.getAddress()}`); |
There was a problem hiding this comment.
nit: Remove the multiple Wallet Address prints and marge it into one after this if/else
console.log(Evm Wallet Address: ${evmWalletProvider.getAddress()});
| // Configure ZeroDev Wallet Provider with CDP Wallet as signer | ||
| const zeroDevConfig = { | ||
| signer: evmWalletProvider, |
There was a problem hiding this comment.
nit: After the toSigner refactor, pass in signer: evmWalletProvider.toSigner()
jstinhw
commented
Apr 14, 2025
|
jstinhw
commented
Apr 17, 2025
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Replace configureWithSigner with configureWithWallet
- Replace `0x${string}` type with Address, Hex or Hash
- networkId as config instead of network
- Update `network` params to `networkId`
- Use `!` when getting chainId in sendTransaction
- Remove unused `getSigner`
- Merge evm wallet address log in example- added "toSigner" helper func to evmWalletProvider - updated type of signer to Account in config of zeroDevWalletProvider
e338e2a to
f733210Comparef733210 to
23c9b79Compare
Description
This PR introduces a new
ZeroDevWalletProviderandZeroDevWalletActionProvider, which wraps existingEvmWalletProviderinstances (e.g.,privyEvmWalletProvider,cdpWalletProvider) to enable account abstraction via ZeroDev’s infrastructure. The result is a fully chain-abstracted smart account that can be used seamlessly across different EVM-compatible networks.In addition to introducing the
ZeroDevWalletProvider, this PR updates thehashMessageimport from@coinbase/coinbase-sdktoviem. Previously,@coinbase/coinbase-sdkre-exported the same function fromethers.js, but this change consolidates our hashing logic underviemdirectly.Key points:
ZeroDevWalletProvider, leveraging an existing signer (e.g.,privyEvmWalletProvider) to create a ZeroDev smart contract wallet.ZeroDevWalletActionProvider, providing the action to get chain abstracted balance (getCAB) from the smart account.hashMessageusage to referenceviemdirectly instead of relying on theethers.jsfunction from@coinbase/coinbase-sdk.Tests
Checklist
A couple of things to include in your PR for completeness: