Feat/dynamic server wallets - #738

Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom
dynamic-labs-oss:feat/dynamic-server-wallets
Closed

Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom
dynamic-labs-oss:feat/dynamic-server-wallets

Conversation

@matthew1809

@matthew1809matthew1809 commented May 29, 2025

Copy link
Copy Markdown

Description

Add Dynamic as a wallet provider (PR for app generation to follow)

Tests

I tested with the example chatbot.

Other

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@cb-heimdall

cb-heimdall commented May 29, 2025

Copy link
Copy Markdown

🟡 Heimdall Review Status

RequirementStatusMore Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0
From .codeflow.yml1
Additional review requirements
Show calculation
Max0
0
From CODEOWNERS0
Global minimum0
Max 1
1
1 if commit is unverified0
Sum1

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation wallet provider New wallet provider example New example agent typescript labels May 29, 2025
@matthew1809

matthew1809 commented May 29, 2025

Copy link
Copy Markdown
Author

Hi @murrlincoln, let me know if you'd like anything changed here!

@phdargen

phdargen commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below

@phdargen

phdargen commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks

phdargen
phdargen reviewed Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider

@phdargenphdargenAug 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch
Adds -> Added

phdargen
phdargen reviewed Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"

@phdargenphdargenAug 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code

phdargen
phdargen reviewed Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
"dependencies": {
"@coinbase/agentkit": "workspace:*",
"@coinbase/agentkit-langchain": "^0.3.0",
"@dynamic-labs-wallet/core": "^0.0.71",

@phdargenphdargenAug 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.

Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json

phdargen
phdargen reviewed Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
pythActionProvider(),
walletActionProvider(),
erc20ActionProvider(),
cdpApiActionProvider({

@phdargenphdargenAug 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider

phdargen
phdargen reviewed Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
apiKeyName: process.env.CDP_API_KEY_NAME as string,
apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
}),
splActionProvider(),

@phdargenphdargenAug 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.

I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration

@phdargen

phdargen commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets

phdargen
phdargen reviewed Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
type: "json-rpc",
},
chain,
transport: http(),

@phdargenphdargenAug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL

phdargen
phdargen reviewed Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
throw new Error(`Chain with ID ${chainId} not found`);
}

const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({

@phdargenphdargenAug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove

@matthew1809
matthew1809force-pushed the feat/dynamic-server-wallets branch from 55c414c to 12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen mentioned this pull request Sep 30, 2025
Closed
10 tasks
@phdargen

phdargen commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Closing due to inactivity

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees

No one assigned

Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Feat/dynamic server wallets - #738
Closed
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Closed
Feat/dynamic server wallets#738
matthew1809 wants to merge 6 commits into
coinbase:mainfrom 
dynamic-labs-oss:feat/dynamic-server-wallets
Conversation
@matthew1809
@matthew1809matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Description
Add Dynamic as a wallet provider (PR for app generation to follow)
Tests
I tested with the example chatbot.
Other
  •  Added documentation to all relevant README.md files
  •  Added a changelog entry
@cb-heimdall
cb-heimdall
commented
May 29, 2025

Copy link


Copy Markdown

🟡 Heimdall Review Status
RequirementStatusMore Info
Reviews
🟡
0/1
Denominator calculation
Show calculation
1 if user is bot0
1 if user is external0
2 if repo is sensitive0

From .codeflow.yml1

Additional review requirements

Show calculation
Max0
0

From CODEOWNERS0
Global minimum0
Max
1

1
1 if commit is unverified0
Sum1
@github-actionsgithub-actionsBot
added

documentation
Improvements or additions to documentation
wallet provider
New wallet provider
example
New example agent
typescript

labels
May 29, 2025
@matthew1809
matthew1809
commented
May 29, 2025

Copy link


Copy Markdown

Author
Hi @murrlincoln, let me know if you'd like anything changed here!
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Hi @matthew1809, thanks for your contribution! Could you please rebase against main and bump the dynamic packages to the latest versions (if appropriate), then I will do some testing. A few initial comments below
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
Please make sure to run pnpm run format and pnpm run lint before you commit, there are several unused imports/vars that would lead to failed checks
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/.changeset/small-banks-reply.md
"@coinbase/agentkit": minor
---

Adds Dynamic as wallet provider
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor -> patch

Adds -> Added
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/.env-local
DYNAMIC_BASE_API_URL=https://app.dynamicauth.com
DYNAMIC_BASE_MPC_RELAY_API_URL=https://relay.dynamicauth.com

# Optional Network ID. If you'd like to use a Dynamic Solana wallet, set to "solana-devnet". Otherwise, defaults to "base-sepolia"
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaults to "mainnet-beta" according to chatbot code
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/package.json
 "dependencies": {
 "@coinbase/agentkit": "workspace:*",
 "@coinbase/agentkit-langchain": "^0.3.0",
 "@dynamic-labs-wallet/core": "^0.0.71",
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dynamic dependencies needed here? If so, should use the same versions as in typescript/agentkit/package.json.
Please update other dep to be consistent with https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/package.json
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 pythActionProvider(),
 walletActionProvider(),
 erc20ActionProvider(),
 cdpApiActionProvider({
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #785, cdpApiActionProvider needs to be renamed to legacyCdpApiActionProvider
phdargen
phdargen
reviewed
Aug 4, 2025
View reviewed changes
Comment threadtypescript/examples/langchain-dynamic-chatbot/chatbot.ts
 apiKeyName: process.env.CDP_API_KEY_NAME as string,
 apiKeyPrivateKey: process.env.CDP_API_KEY_PRIVATE_KEY as string,
 }),
 splActionProvider(),
@phdargenphdargenAug 4, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mixing up evm-only and svm-only actions, while the wallet setup is only for svm.
I'd suggest to check from config vars wether evm or svm wallet should be initialized and then add actions accordingly. Have a look at https://github.com/coinbase/agentkit/blob/main/typescript/examples/langchain-cdp-chatbot/chatbot.ts for inspiration
@phdargen
phdargen
commented
Aug 4, 2025

Copy link


Copy Markdown

Contributor
It would be great if you could include the result of some manual end-to-end testing in the PR description including prompt + reply for both evm and svm wallets
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 type: "json-rpc",
 },
 chain,
 transport: http(),
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #824, this should include an optional config to set custom RPC_URL
phdargen
phdargen
reviewed
Aug 18, 2025
View reviewed changes
Comment threadtypescript/agentkit/src/wallet-providers/dynamicEvmWalletProvider.ts
 throw new Error(`Chain with ID ${chainId} not found`);
 }

 const publicClient = (dynamic as DynamicEvmWalletClient).createViemPublicClient({
@phdargenphdargenAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicClient appears to be unused, please remove
@matthew1809
matthew1809force-pushed
the
feat/dynamic-server-wallets
branch
from
55c414c to
12b91f3CompareAugust 19, 2025 12:58
@phdargenphdargen
mentioned this pull request
Sep 30, 2025
 Closed

10 tasks
@phdargen
phdargen
commented
Mar 17, 2026

Copy link


Copy Markdown

Contributor
Closing due to inactivity
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@phdargenphdargenphdargen left review comments
@murrlincolnmurrlincolnAwaiting requested review from murrlincolnmurrlincoln is a code owner

Assignees


No one assigned


Labels

documentationImprovements or additions to documentationexampleNew example agenttypescriptwallet providerNew wallet provider

Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@matthew1809@cb-heimdall@phdargen@Tanker187