Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Updated Integration Guide - #440

Open
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications
Open

Updated Integration Guide#440
raj-cometchat wants to merge 16 commits into
mainfrom
docs/new-flutter-push-notifications

Conversation

@raj-cometchat

@raj-cometchatraj-cometchat commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Type of Change

  • Documentation correction/update
  • New documentation
  • Improvement to existing documentation
  • Typo fix
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document
  • My branch name follows the naming convention
  • My changes follow the documentation style guide
  • I have checked for spelling and grammar errors
  • All links in my changes are valid and working
  • My changes are accurately described in this pull request

Additional Information

Screenshots (if applicable)

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟢 ReadyView PreviewJul 27, 2026, 5:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mintlify

mintlifyBot commented Jul 27, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

ProjectStatusPreviewUpdated (UTC)
cometchat🟡 BuildingJul 27, 2026, 5:32 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

raj-dubey1
raj-dubey1 previously approved these changes Jul 28, 2026
ashfaqcometchatand others added 2 commits July 28, 2026 15:37
Replace the copy-the-UI-Kit-sample approach with the released
com.cometchat:push-notifications-android:1.0.0 drop-in SDK, mirroring the
new Flutter guide's structure. Covers dependency setup, Application init
via PNConfiguration.Builder, forwarding FCM payloads to
handlePushNotification, token registration/refresh, notification-tap and
call-event listeners, badge count, testing, and troubleshooting.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s-sdk
Rewrite Android push guide for drop-in push-notifications-android SDK
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 28, 2026
Consolidates the two legacy iOS pages (APNs + FCM copy-files patterns)
into a single notifications/ios-push-notifications.mdx that documents
the CometChatPushNotifications drop-in SDK: SPM/CocoaPods install,
AppDelegate + SceneDelegate wiring, CometChatPushNotificationsDelegate
for taps and calls, foreground suppression, badge, and troubleshooting.
Updates docs.json nav + redirects, the notifications and getting-started
landing pages (single "iOS" card, no FCM-iOS Firebase tab), and stray
cross-references from Flutter VoIP and legacy iOS extensions pages.
The legacy 2.0 extensions page is out of scope for the push SDK
rewrite; the redirect on the old slug handles the old link.
shardul-cometchat
shardul-cometchat previously approved these changes Jul 28, 2026
ashfaqcometchat
ashfaqcometchat previously approved these changes Jul 31, 2026
adityakotasthane07
adityakotasthane07 previously approved these changes Aug 7, 2026
@jitvarpatil

Copy link
Copy Markdown
Contributor

Docs review — 🟠 Request changes

A large push-notifications restructure (18 files, +1,104/−2,831) consolidating the split Flutter (android+ios) and iOS (APNs+FCM) push pages into single flutter-push-notifications / ios-push-notifications pages. Content and redirect intent are good — but there's an execution bug that will leave blank pages and silently defeat the redirects.

🟠 P1 — 3 old pages emptied instead of deleted (breaks their own redirects)

git diff --name-status shows these as M (modified to 0 bytes), still tracked (empty blob e69de29b), not deleted:

  • notifications/flutter-push-notifications-android.mdx → 0 bytes
  • notifications/flutter-push-notifications-ios.mdx → 0 bytes
  • notifications/ios-apns-push-notifications.mdx → 0 bytes

Only ios-fcm-push-notifications.mdx was correctly git rm'd.

Why it matters: the PR does add redirects for all four old URLs (e.g. /notifications/flutter-push-notifications-android → /notifications/flutter-push-notifications) — which is exactly right — but a redirect only fires when no page exists at that path. Since these 3 files still exist (empty), Mintlify serves a blank page instead of applying the redirect. So the consolidation half-works: ios-fcm redirects correctly (properly deleted); the other 3 render blank and their redirects are dead-on-arrival.

Fix: actually delete them —

git rm notifications/flutter-push-notifications-android.mdx \
notifications/flutter-push-notifications-ios.mdx \
notifications/ios-apns-push-notifications.mdx

— then the already-present redirects take effect.

🟠 P1 — in-content link to a deleted page

notifications/push-overview.mdx still links to /notifications/ios-fcm-push-notifications (now deleted). A redirect exists so it won't hard-404, but an in-content link shouldn't rely on a redirect — point it directly at /notifications/ios-push-notifications.

✅ What passed

  • Redirects added for all four consolidated old URLs + push-integration → push-overview, with correct destinations. Good coverage — just undermined by the empty files above.
  • Merged content is clean: both new pages have proper frontmatter (title: "Flutter" / "iOS"), a single consistent version pin (cometchat_push_notifications: ^1.0.1 — no version drift), no placeholders/TODOs, and no broken "see above/below" cross-refs from the merge.
  • Build/nav: 0 unresolved nav refs. (The /notifications/overview orphan the analyzer flagged is pre-existing — not in this PR.)

Well-intentioned consolidation with correct redirects and clean merged content — it just needs the 3 pages deleted rather than emptied, plus the one in-content link updated. Happy to re-check once that's done.

🤖 Automated docs review (Mintlify link/redirect/nav/content checks).

Both 'iOS - FCM' and 'iOS - APNs' sample cards pointed at
.../SampleAppPushNotificationAPNs/Push Notification + VoIP, which
404s (that subfolder no longer exists in the v5 branch). Collapse
to a single 'iOS' card pointing at the SampleAppPushNotificationAPNs
folder itself, which is where the sample now lives.
The 'resolved conflicts' merge on this branch resurrected
notifications/ios-apns-push-notifications.mdx as an empty file and
reintroduced the split 'iOS (APNs)' / 'iOS (FCM)' cards on
notifications/push-overview.mdx pointing at deleted slugs. A blank
file at the old path silently defeats the redirect, so:
- git rm the empty ios-apns page so the redirect fires again.
- Collapse the two iOS cards on push-overview into a single 'iOS'
card pointing at /notifications/ios-push-notifications.
Same merge-conflict-resolution regression as the iOS side: the
'resolved conflicts' merge on this branch resurrected
notifications/flutter-push-notifications-android.mdx and
notifications/flutter-push-notifications-ios.mdx as empty (0-byte)
files, which silently defeats their /notifications/flutter-push-
notifications redirects, and reintroduced the split
'Flutter (Android)' / 'Flutter (iOS)' cards on push-overview
pointing at the deleted slugs. Also the two Flutter sample-app
cards on the notifications landing page pointed at the same
sample_app_push_notifications URL.
- git rm both empty Flutter pages so the redirects fire again.
- Collapse the two Flutter cards on push-overview into a single
'Flutter' card pointing at /notifications/flutter-push-notifications.
- Collapse the two Flutter sample-app cards on notifications.mdx
into one 'Flutter' card at the same working URL.
@jitvarpatil

Copy link
Copy Markdown
Contributor

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

@jitvarpatiljitvarpatil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — ✅ Approve

Both P1 findings from my earlier review are fully resolved (the new commits — "Re-delete empty Flutter push pages…", "Re-delete ios-apns page and fix stale iOS links…" — address them directly). Re-verified on head 0df4bdd.

✅ Fixed

  • All 4 old pages now properly deleted — analyzer reports removed: 4 (was removed: 1 with 3 emptied to 0 bytes). No 0-byte .mdx files remain in notifications/.
  • All 4 deleted URLs have working redirects ([2a] 0 of 4 unredirected) — and now that the files are genuinely gone, the redirects will actually fire:
    • flutter-push-notifications-android / -iosflutter-push-notifications
    • ios-apns-push-notifications / ios-fcm-push-notificationsios-push-notifications
  • Broken in-content link fixed[4] 0 broken links (was 1); push-overview.mdx now links directly to /notifications/ios-push-notifications.
  • 0 nav breaks. (The /notifications/overview orphan is pre-existing — not this PR.)

Combined with the already-verified merged content (proper frontmatter, single consistent version pin cometchat_push_notifications: ^1.0.1, no placeholders/contradictions), the consolidation is now correct end-to-end.

Nicely done on the redirect coverage. Ready to merge. 🚀

🤖 Automated docs review — re-check after fixes.

suraj-chauhan-cometchat added a commit that referenced this pull request Aug 28, 2026
The push-getting-started page is introduced by the still-open Flutter PR
#440; until it merges, link the shared setup prerequisite
to the existing notifications/push-overview page so the RN guide has no
dead links on main.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@raj-cometchat@jitvarpatil@raj-dubey1@shardul-cometchat@ashfaqcometchat@adityakotasthane07@DhruvKushvaha2004