Skip to content

Fix observer list losing filtering - #663

Merged
idormenco merged 17 commits into
commitglobal:mainfrom
imdeaconu:fix-observer-list-losing-filtering
Sep 17, 2024
Merged

Fix observer list losing filtering#663
idormenco merged 17 commits into
commitglobal:mainfrom
imdeaconu:fix-observer-list-losing-filtering

Conversation

@imdeaconu

@imdeaconuimdeaconu commented Sep 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

The proposed filtering system

The proposed filtering system uses reusable components that encapsulate their business logic so their behavior should be identical throughout the app. The system uses query params as a single source of truth so the state is saved through navigation and can be bookmarked or shared via an URL.

@vercel

vercelBot commented Sep 11, 2024

Copy link
Copy Markdown

@imdeaconu is attempting to deploy a commit to the Code for Romania Team on Vercel.

A member of the Team first needs to authorize it.

@imdeaconu
imdeaconu marked this pull request as draft September 11, 2024 08:30
@imdeaconu
imdeaconu marked this pull request as ready for review September 11, 2024 08:39
idormenco
idormenco requested changes Sep 16, 2024
View reviewed changes
Comment threadweb/src/features/filtering/components/ActiveFilters.tsx Outdated
Comment threadweb/src/features/filtering/components/ObserverStatusSelect.tsx Outdated
Comment threadweb/src/features/filtering/components/ObserverStatusSelect.tsx Outdated
Comment threadweb/src/features/filtering/components/ObserverStatusSelect.tsx Outdated
Comment threadweb/src/features/filtering/components/ObserverTagsSelect.tsx Outdated
idormenco
idormenco requested changes Sep 16, 2024
View reviewed changes
Comment threadweb/src/features/filtering/components/ObserverStatusSelect.tsx Outdated
idormenco
idormenco requested changes Sep 17, 2024
View reviewed changes
Comment thread...features/monitoring-observers/components/MonitoringObserversList/MonitoringObserversList.tsx Outdated
Comment threadweb/src/features/filtering/filtering-enums.ts Outdated
Comment thread...features/monitoring-observers/components/MonitoringObserversList/MonitoringObserversList.tsx
Comment thread...features/monitoring-observers/components/MonitoringObserversList/MonitoringObserversList.tsx Outdated
Comment threadweb/src/features/filtering/components/GenericSelectFilter.tsx Outdated
@idormenco

idormenco commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

LGTM

@idormenco
idormenco merged commit d8f5703 into commitglobal:mainSep 17, 2024
idormenco pushed a commit that referenced this pull request Sep 18, 2024
@imdeaconu@idormenco
Fix observer list losing filtering (#663)
b6d9267
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
idormenco added a commit that referenced this pull request Sep 18, 2024
@idormenco@imdeaconu
Add locations feature (#677)
b6d9d70
* Add locations feature
* Fix observer list losing filtering (#663)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
* [NGO Admin] Rewrite the tag selector component (#675)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* make public an endpoint ,cleanuo
* Implement export data for locations and citizen reports
---------
Co-authored-by: Iulian Deaconu <imdeaconu@gmail.com>
idormenco pushed a commit that referenced this pull request Sep 18, 2024
@imdeaconu@idormenco
Fix observer list losing filtering (#663)
477cdee
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
idormenco added a commit that referenced this pull request Sep 18, 2024
@idormenco@imdeaconu
Add locations feature (#677)
e89e004
* Add locations feature
* Fix observer list losing filtering (#663)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
* [NGO Admin] Rewrite the tag selector component (#675)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* make public an endpoint ,cleanuo
* Implement export data for locations and citizen reports
---------
Co-authored-by: Iulian Deaconu <imdeaconu@gmail.com>
@imdeaconu
imdeaconu deleted the fix-observer-list-losing-filtering branch October 1, 2024 09:19
idormenco pushed a commit that referenced this pull request Oct 4, 2024
@imdeaconu@idormenco
Fix observer list losing filtering (#663)
f7d60f8
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
idormenco added a commit that referenced this pull request Oct 4, 2024
@idormenco@imdeaconu
Add locations feature (#677)
588b124
* Add locations feature
* Fix observer list losing filtering (#663)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
* [NGO Admin] Rewrite the tag selector component (#675)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* make public an endpoint ,cleanuo
* Implement export data for locations and citizen reports
---------
Co-authored-by: Iulian Deaconu <imdeaconu@gmail.com>
idormenco pushed a commit that referenced this pull request Oct 4, 2024
@imdeaconu@idormenco
Fix observer list losing filtering (#663)
204a3ba
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
idormenco added a commit that referenced this pull request Oct 4, 2024
@idormenco@imdeaconu
Add locations feature (#677)
046dcb4
* Add locations feature
* Fix observer list losing filtering (#663)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* create reusable filtering containers
* add ObserverTags component
* fix ObserversTagSelect
* remove old filtering system from observers list
* feature: remove just one item from a filter array
* fix back button not keeping filtering in ObserversList
* update active filter badges
* add titles to back buttons
* rename components and use enums instead of magic strings
* misc: various changes
* [NGO Admin] Rewrite the tag selector component (#675)
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* make public an endpoint ,cleanuo
* Implement export data for locations and citizen reports
---------
Co-authored-by: Iulian Deaconu <imdeaconu@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idormencoidormencoidormenco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NGO Admin] [Monitoring observers] Filter reset on back button in monitoring observers list

2 participants

@imdeaconu@idormenco