Skip to content

Enhance filtering - #685

Merged
idormenco merged 34 commits into
commitglobal:mainfrom
imdeaconu:enhance-tables
Sep 25, 2024
Merged

Enhance filtering#685
idormenco merged 34 commits into
commitglobal:mainfrom
imdeaconu:enhance-tables

Conversation

@imdeaconu

@imdeaconuimdeaconu commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Related to #608

  • "Entry" ID & "Language" columns are missing from the extended table header ([see column settings expanded]
  • To add "PSI" in "Form type" filter options. The user should be able to filter the responses by Form type = PSI
  • Filters implemented:
  • "Questions answered" - dropdown 3 options: None, Some, All.
  • "Question notes" - dropdown true/false selection: Yes / No
  • "Media files" - dropdown true/false selection: Yes / No

@imdeaconu
fix: make dropdown menus scrollable
0fe3fbe
@imdeaconu
fix: truncate overflowing table columns
4ca1a44
@imdeaconu
Merge branch 'commitglobal:main' into main
921aa13
@imdeaconu
Merge branch 'commitglobal:main' into main
e5a2869
@imdeaconu
Merge branch 'commitglobal:main' into main
7866a67
@imdeaconu
fix: add new columns and make default column size larger
f6f7929
@imdeaconu
Merge branch 'commitglobal:main' into main
9ea6c42
@imdeaconu
Merge branch 'commitglobal:main' into main
1bd449d
@imdeaconu
Squashed commit of the following:
c9874d1
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
@imdeaconu
Merge branch 'commitglobal:main' into main
b7715f3
@imdeaconu
Squashed commit of the following:
0facf65
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
@imdeaconu
chore: remove unused import
67f681d
@imdeaconu
chore: delete duplicated / unused classes
8d73252
@imdeaconu
Merge branch 'commitglobal:main' into main
63b21b9
@imdeaconu
Merge branch 'main' into enhance-tables
ddfc4ea
@imdeaconu
WIP: start creating new filters
d3154ed
@imdeaconu
Merge branch 'commitglobal:main' into main
1892e6e
@imdeaconu
feature: add searching to MonitoringObserversTagFilter
abb7c01
@imdeaconu
Merge branch 'commitglobal:main' into main
9d0b8ae
@imdeaconu
chore: update config files
c9fcd3e
@imdeaconu
Revert "[NGO Admin] Rewrite the tag selector component (commitglobal#675
333ba49
)"
This reverts commit 2ad0e90.
@imdeaconu
Merge branch 'main' ofhttps://github.com/commitglobal/votemonitor
580b68e
@imdeaconu
Merge branch 'main' into enhance-tables
10eecdf
@imdeaconu
revert to old filtering system and add questions answered dropdown
ae88993
@imdeaconu
add has notes
4e52b22
@imdeaconu
disable filtering by curent tags
1bc663d
@imdeaconu
add filters
d6e5368
@vercel

vercelBot commented Sep 24, 2024

Copy link
Copy Markdown

@imdeaconu is attempting to deploy a commit to the Code for Romania Team on Vercel.

A member of the Team first needs to authorize it.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 24, 2024
View reviewed changes
Comment threadweb/src/components/ui/tag-selector.tsx Fixed
Comment threadweb/src/components/ui/tag-selector.tsx Fixed
Comment threadweb/src/components/ui/tag-selector.tsx Fixed
Comment threadweb/src/features/monitoring-observers/filtering/MonitoringObserverTagsSelect.tsx Fixed
@imdeaconuimdeaconu changed the title Enhance tablesEnhance filteringSep 25, 2024
idormencoand others added 7 commits September 25, 2024 14:40
@idormenco
Cleanup, improve performance of ps select
e2f3e1c
@idormenco
Update locations-levels.ts
a132b1c
@idormenco
Feature/citizen reports guides (commitglobal#686)
32d2c56
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
@idormenco
fix build, and tag selector
fbb67a3
@idormenco
Feature/citizen reports guides (commitglobal#686)
a9dda6e
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
@imdeaconu@idormenco
Feature/citizen reports guides (commitglobal#686) (#2)
5210d67
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
Co-authored-by: Ion Dormenco <idormenco@gmail.com>
@imdeaconu
Merge branch 'commitglobal:main' into enhance-tables
29e575f
@idormenco

idormenco commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

LGTM thanks a lot

@idormenco
idormenco merged commit 4d73324 into commitglobal:mainSep 25, 2024
idormenco added a commit that referenced this pull request Oct 4, 2024
@imdeaconu@idormenco
Enhance filtering (#685)
974eb4e
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* fix: add new columns and make default column size larger
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* WIP: start creating new filters
* feature: add searching to MonitoringObserversTagFilter
* chore: update config files
* Revert "[NGO Admin] Rewrite the tag selector component (#675)"
This reverts commit 2ad0e90.
* revert to old filtering system and add questions answered dropdown
* add has notes
* disable filtering by curent tags
* add filters
* Cleanup, improve performance of ps select
* Update locations-levels.ts
* Feature/citizen reports guides (#686)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
* fix build, and tag selector
* Feature/citizen reports guides (#686)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
* Feature/citizen reports guides (#686) (#2)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
Co-authored-by: Ion Dormenco <idormenco@gmail.com>
---------
Co-authored-by: Ion Dormenco <idormenco@gmail.com>
idormenco added a commit that referenced this pull request Oct 4, 2024
@imdeaconu@idormenco
Enhance filtering (#685)
0bd0475
* fix: make dropdown menus scrollable
* fix: truncate overflowing table columns
* fix: add new columns and make default column size larger
* Squashed commit of the following:
commit 742f250
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:55 2024 +0300
add read notification checkmark
commit ea11fa0
Author: imdeaconu <imdeaconu@gmail.com>
Date: Wed Sep 11 19:54:30 2024 +0300
add read notification column
* Squashed commit of the following:
commit d8833dc
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 13:29:31 2024 +0300
WIP: add selector functionality
commit 3608c0e
Author: imdeaconu <imdeaconu@gmail.com>
Date: Fri Sep 13 10:00:05 2024 +0300
WIP: create new tags input
* chore: remove unused import
* chore: delete duplicated / unused classes
* WIP: start creating new filters
* feature: add searching to MonitoringObserversTagFilter
* chore: update config files
* Revert "[NGO Admin] Rewrite the tag selector component (#675)"
This reverts commit 2ad0e90.
* revert to old filtering system and add questions answered dropdown
* add has notes
* disable filtering by curent tags
* add filters
* Cleanup, improve performance of ps select
* Update locations-levels.ts
* Feature/citizen reports guides (#686)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
* fix build, and tag selector
* Feature/citizen reports guides (#686)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
* Feature/citizen reports guides (#686) (#2)
* Add citizen reports api
* rename api feature
* refactor guides
* Add tests, rename folder, fix selects
* Update EditTextGuide.tsx
* Update file-uploader.tsx
* Update EditTextGuide.tsx
Co-authored-by: Ion Dormenco <idormenco@gmail.com>
---------
Co-authored-by: Ion Dormenco <idormenco@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imdeaconu@idormenco@github-advanced-security