Uh oh!
There was an error while loading. Please reload this page.
Shows deprecated warning before prompt questions - #1146
Conversation
marcosdotme
commented
May 28, 2024
Relates to #1135 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1146 +/- ##
==========================================
+ Coverage 97.33% 97.54% +0.20%
==========================================
Files 42 55 +13 Lines 2104 2486 +382 ==========================================
+ Hits 2048 2425 +377 - Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It's a bad dev experience getting warning/failures after all questions answered.
The deprecated text was not shown when `cz commit --help`
Lee-W
left a comment
There was a problem hiding this comment.
Would it be possible for us to also document the -- behavior in help text 🤔
| retry: bool = self.arguments.get("retry") | ||
| no_retry: bool = self.arguments.get("no_retry") | ||
| retry_after_failure: bool = self.config.settings.get("retry_after_failure") |
There was a problem hiding this comment.
Should we add a default value to these get?
There was a problem hiding this comment.
Hmmm, we can add a explicit default value but .get has a default value to None if not specified.
There was a problem hiding this comment.
Yep, but None is not a bool, False would be better 🙂
| out.warn( | ||
| "signoff mechanic is deprecated, please use `cz commit -- -s` instead.\n" | ||
| ) | ||
| extra_args = self.arguments.get("extra_cli_args", "--") + " -s" |
marcosdotme
commented
Jun 3, 2024
Of course. I will add this too |
Description
Shows deprecated warning before prompt questions to dev, for an better experience.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testScreenshots
Shows deprecated warning before prompt questions
Shows deprecated warning on command help text
Dont' shows deprecated warning if uses
--signoffoption the right way