Uh oh!
There was an error while loading. Please reload this page.
fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch' - #1209
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## v4 #1209 +/- ##
=====================================
Coverage ? 97.57% =====================================
Files ? 55 Lines ? 2516 Branches ? 0 =====================================
Hits ? 2455 Misses ? 61 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lee-W
commented
Aug 16, 2024
Looks good to me. but we probably won't want to bump a major version for it. so I would suggest we remove the ! in all the commits |
AdrianDC
commented
Aug 16, 2024
Thanks for the feedback. IMO this should be a ! change, as any user having Could go along other fixes such as #1206 and #1207 Example local usage until released:https://gitlab.com/RadianDevCore/tools/gcil/-/blob/53e6cb534ff77704ac9b9dc51d755b9965556910/.pre-commit-config.yaml#L54 |
Lee-W
commented
Aug 16, 2024
If that's the case, we'll need to wait for our next release. @woile we probably can create a v4 branch already? |
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.6.1 to 0.6.2. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.6.1...0.6.2) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Details: 'args: [...]' is not able to access '-nr NO_RAISE' global arguments for example from a arguments configuration --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
Details: Pushing the same history from 'develop' to 'staging' for example fails because range 'origin/HEAD..HEAD' is empty > No commit found with range: 'origin/HEAD..HEAD' --- Signed-off-by: Adrian DC <radian.dc@gmail.com>
5885a04 to
5e4cbd6CompareLee-W
commented
Nov 10, 2024
Just change the base to v4. and let's merge it 🚀 |
Description
fix(pre-commit-hooks)!: move 'check' to 'args' for global options
Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
arguments for example from a arguments configuration
fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'
Details: Pushing the same history from 'develop' to 'staging' for
example fails because range 'origin/HEAD..HEAD' is empty
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Error
No commit found with range: 'origin/HEAD..HEAD'not raisedSteps to Test This Pull Request
Push same history to develop then staging