Skip to content

refactor: improve readability and fix typos - #1416

Merged
Lee-W merged 1 commit into
commitizen-tools:refactorsfrom
bearomorphism:refactor-0516
May 22, 2025
Merged

refactor: improve readability and fix typos#1416
Lee-W merged 1 commit into
commitizen-tools:refactorsfrom
bearomorphism:refactor-0516

Conversation

@bearomorphism

@bearomorphismbearomorphism commented May 15, 2025

Copy link
Copy Markdown
Collaborator

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov

codecovBot commented May 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@a0cc490). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## refactors #1416 +/- ##
============================================
Coverage ? 97.57% ============================================
Files ? 57 Lines ? 2678 Branches ? 0 ============================================
Hits ? 2613 Misses ? 65 Partials ? 0 
FlagCoverage Δ
unittests97.57% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
bearomorphism marked this pull request as draft May 15, 2025 18:59
@bearomorphism
bearomorphism marked this pull request as ready for review May 15, 2025 19:00
Comment threadcommitizen/bump.py Outdated
Comment threadcommitizen/cli.py Outdated
Comment threadcommitizen/cz/utils.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, minor nits left

Comment threadcommitizen/cz/utils.py Outdated
Comment threadcommitizen/bump.py Outdated
@bearomorphism

Copy link
Copy Markdown
CollaboratorAuthor

Just added some modifications on bump.py, please review

Comment threadcommitizen/bump.py Outdated
@Lee-W
Lee-W changed the base branch from master to refactorsMay 22, 2025 03:24
@Lee-W
Lee-W merged commit 3d3b90c into commitizen-tools:refactorsMay 22, 2025
@bearomorphism
bearomorphism deleted the refactor-0516 branch June 1, 2025 05:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bearomorphism@noirbizarre@woile@Lee-W