Skip to content

refactor(BaseConfig): update function name, upgrade mypy version - #1444

Merged
Lee-W merged 2 commits into
commitizen-tools:refactorsfrom
bearomorphism:refactor-config
May 23, 2025
Merged

refactor(BaseConfig): update function name, upgrade mypy version#1444
Lee-W merged 2 commits into
commitizen-tools:refactorsfrom
bearomorphism:refactor-config

Conversation

@bearomorphism

Copy link
Copy Markdown
Collaborator

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

Comment threadcommitizen/config/base_config.py
@codecov

codecovBot commented May 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@225fd76). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## refactors #1444 +/- ##
============================================
Coverage ? 97.62% ============================================
Files ? 57 Lines ? 2654 Branches ? 0 ============================================
Hits ? 2591 Misses ? 63 Partials ? 0 
FlagCoverage Δ
unittests97.62% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
bearomorphismforce-pushed the refactor-config branch 7 times, most recently from 45fe774 to 117e61cCompareMay 20, 2025 15:51
@bearomorphismbearomorphism changed the title refactor(BaseConfig): remove path propertyrefactor(BaseConfig): update function nameMay 20, 2025
@bearomorphismbearomorphism changed the title refactor(BaseConfig): update function namerefactor(BaseConfig): update function name, upgrade mypy versionMay 20, 2025
Comment threadcommitizen/config/base_config.py Outdated
@Lee-W
Lee-W changed the base branch from master to refactorsMay 23, 2025 03:22
@Lee-W
Lee-W merged commit 50fd65f into commitizen-tools:refactorsMay 23, 2025
@bearomorphism
bearomorphism deleted the refactor-config branch June 1, 2025 05:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bearomorphism@Lee-W