Skip to content

fix(bump): extract option validation and new version resolution - #1646

Merged
Lee-W merged 1 commit into
commitizen-tools:v4-10-1from
bearomorphism:bump-refactor
Nov 19, 2025
Merged

fix(bump): extract option validation and new version resolution#1646
Lee-W merged 1 commit into
commitizen-tools:v4-10-1from
bearomorphism:bump-refactor

Conversation

@bearomorphism

@bearomorphismbearomorphism commented Nov 11, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Changes

Relate #1643

  • Refactors
  • Collect all NotAllowed error messages and raise it at the end of option validation process

@codecov

codecovBot commented Nov 11, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-10-1@280bea0). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## v4-10-1 #1646 +/- ##
==========================================
Coverage ? 98.60% ==========================================
Files ? 60 Lines ? 2651 Branches ? 0 ==========================================
Hits ? 2614 Misses ? 37 Partials ? 0
FlagCoverage Δ
unittests98.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphismbearomorphism changed the title refactor(bump): extract option validation and new version resolution …fix(bump): extract option validation and new version resolution …Nov 11, 2025
@Lee-WLee-W added this to the 4.10.1 milestone Nov 16, 2025
Lee-W
Lee-W reviewed Nov 16, 2025
View reviewed changes
Comment threadcommitizen/commands/bump.py
Comment threadcommitizen/commands/bump.py
@Lee-WLee-W changed the title fix(bump): extract option validation and new version resolution …fix(bump): extract option validation and new version resolutionNov 16, 2025
Lee-W
Lee-W reviewed Nov 18, 2025
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good. one minor question

Comment threadcommitizen/commands/bump.py
Comment threadtests/commands/test_bump_command.py Outdated
@bearomorphismbearomorphism mentioned this pull request Nov 18, 2025
Closed
@Lee-WLee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Nov 19, 2025
@Lee-W
Lee-W merged commit f52f532 into commitizen-tools:v4-10-1Nov 19, 2025
21 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@woilewoileAwaiting requested review from woile
@noirbizarrenoirbizarreAwaiting requested review from noirbizarre

Assignees

No one assigned

Labels

pr-status: ready-to-mergealmost ready to merge. just keep it for a few days for others to checkpr-status: wait-for-reviewtype: bugtype: refactor

Projects

None yet

Milestone

4.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

@bearomorphism@Lee-W