Uh oh!
There was an error while loading. Please reload this page.
doc(#318): add documentation about WinError 995 - #431
Conversation
Lee-W
left a comment
There was a problem hiding this comment.
Other than the minor documentation reword. Everything looks good. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lee-W
left a comment
There was a problem hiding this comment.
Hi, sorry for the late review. As PyCon TW approaches, I get less time to devote to this project. Here are some errors I found on the changes.
You could test out through
poetry run mkdocs build
poetry run mkdocs serveWould be great if you could add these commands to "how to contribute" so that others can have a better idea on how to test documentation changes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lee-W
commented
Sep 30, 2021
Also, you might need to rebase the latest master branch into this branch to pass the test fail |
Lee-W
commented
Oct 4, 2021
So now we have a single place to view all the FAQs.
Provide the accurate versions that should solve this issue.
According to mkdoc documentation, link to another page in the same documentation can directly use file path. mkdoc documentation: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
Codecov Report
@@ Coverage Diff @@## master #431 +/- ##
==========================================
- Coverage 97.92% 97.37% -0.55%
==========================================
Files 39 39 Lines 1395 1409 +14 ==========================================
+ Hits 1366 1372 +6 - Misses 29 37 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Bogay
commented
Oct 7, 2021
@Lee-W sorry for lately fix and thank you for helping me to rebase the upstream. I have finished those changes. |
These reference-style links should in `[link][id]` format instead of `[link](id)`.
Lee-W
commented
Oct 9, 2021
@Bogay hmmm... that's weird. sometimes codecov just acts weird. never mind, let's merge it |

Description
Add some description related to #318 so that others may find the solution on documentation.
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context